Open
Conversation
Kanchan-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
malrose07,
nchandhi and
toherman-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs minor test-suite cleanup for the orchestrator service by standardizing how the module is referenced in test_orchestrator.py.
Changes:
- Replaced the
orch_modulealias import with a directimport orchestrator. - Updated a couple of test references to use
orchestratorconsistently.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| import pytest | ||
| import orchestrator as orch_module | ||
| import orchestrator |
|
|
||
| # Reset the singleton | ||
| orch_module._orchestrator = None | ||
| orchestrator._orchestrator = None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request makes minor improvements to the test suite for the
orchestratorservice. The changes focus on updating import statements and references to ensure consistency and clarity in the test code.orch_moduletoorchestratorthroughoutsrc/tests/services/test_orchestrator.py, improving readability and consistency in test code. [1] [2] [3]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information