-
Notifications
You must be signed in to change notification settings - Fork 174
Resolve generic collections #1961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| from _pydevd_bundle.pydevd_resolver import get_var_scope, MoreItems, MoreItemsRange | ||
| from typing import Optional | ||
|
|
||
| try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is still required for pre 3.11? There is no FrameType in 3.10.
They're not run as part of the normal PR process, well because changes to Pydevd should generally be made upstream first. This hasn't been happening lately though. I usually run the Pydevd tests manually myself. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The directions here should outline how to run the Pydevd tests: https://github.com/microsoft/debugpy/blob/main/CONTRIBUTING.md#updating-pydevd |
|
so they aren’t run by your CI? other question: are any failures here related to my change? |
No they're not. You have to run them manually.
I don't believe so. There's something going on with thread_count at the moment. Not sure what, but there's been intermittent failures with that test. |
Fixes #1959
TODO:
src/debugpy/_vendored/pydevd/tests_python/run at all?User{Dict,List}also have a fieldKeysView/ValuesView