Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump xunit from 2.9.0 to 2.9.3 #4784

Closed
wants to merge 1 commit into from
+3 −3
Closed

Bump xunit from 2.9.0 to 2.9.3 #4784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Directory.Packages.props
View file
Original file line number Diff line number Diff line change
@@ -133,10 +133,10 @@
<PackageVersion Include="System.IO.FileSystem.AccessControl" Version="5.0.0" />
<PackageVersion Include="System.Net.Http" Version="4.3.4" />
<PackageVersion Include="System.Private.ServiceModel" Version="4.10.3" />
<PackageVersion Include="xunit.extensibility.core" Version="2.9.0" />
<PackageVersion Include="xunit.extensibility.core" Version="2.9.3" />
<PackageVersion Include="Xunit.SkippableFact" Version="1.4.13" />
<PackageVersion Include="xunit" Version="2.9.0" />
<PackageVersion Include="xunit.assert" Version="2.9.0" />
<PackageVersion Include="xunit" Version="2.9.3" />
<PackageVersion Include="xunit.assert" Version="2.9.3" />
<PackageVersion Include="xunit.runner.visualstudio" Version="2.8.2" />
<PackageVersion Include="System.Drawing.Common" Version="8.0.8" />
<PackageVersion Include="Moq" Version="4.20.69" />

Unchanged files with check annotations Beta

View file
src/Microsoft.Health.Fhir.Shared.Web.UnitTests/StartupTests.cs
using var provider = services.BuildServiceProvider();
if (!string.IsNullOrWhiteSpace(instrumentationKey) || !string.IsNullOrWhiteSpace(connectionString))
{
Assert.NotEmpty(services.Where(descriptor =>

Check failure on line 107 in src/Microsoft.Health.Fhir.Shared.Web.UnitTests/StartupTests.cs

GitHub Actions / CodeQL-Build (csharp) 

Do not use Assert.NotEmpty to check if a value exists in a collection. Use Assert.Contains instead. (https://xunit.net/xunit.analyzers/rules/xUnit2030)
descriptor.ImplementationType != null && descriptor.ImplementationType.FullName.Contains("ApplicationInsights", StringComparison.OrdinalIgnoreCase)));
Assert.DoesNotContain(services, descriptor =>
descriptor.ImplementationType != null && descriptor.ImplementationType.FullName.Contains("OpenTelemetry", StringComparison.OrdinalIgnoreCase));
using var provider = services.BuildServiceProvider();
if (!string.IsNullOrWhiteSpace(connectionString))
{
Assert.NotEmpty(services.Where(descriptor =>

Check failure on line 156 in src/Microsoft.Health.Fhir.Shared.Web.UnitTests/StartupTests.cs

GitHub Actions / CodeQL-Build (csharp) 

Do not use Assert.NotEmpty to check if a value exists in a collection. Use Assert.Contains instead. (https://xunit.net/xunit.analyzers/rules/xUnit2030)
descriptor.ImplementationType != null && descriptor.ImplementationType.FullName.Contains("OpenTelemetry", StringComparison.OrdinalIgnoreCase)));
}
else
View file
...alth.Fhir.Shared.Core.UnitTests/Features/Resources/Create/CreateResourceValidatorTests.cs
var result = validator.Validate(createResourceRequest);
Assert.False(result.IsValid);
Assert.True(result.Errors.Count >= 3);
Assert.NotEmpty(result.Errors.Where(e => e.ErrorMessage.Contains("minimum cardinality 1 cannot be null")));

Check failure on line 70 in src/Microsoft.Health.Fhir.Shared.Core.UnitTests/Features/Resources/Create/CreateResourceValidatorTests.cs

GitHub Actions / CodeQL-Build (csharp) 

Do not use Assert.NotEmpty to check if a value exists in a collection. Use Assert.Contains instead. (https://xunit.net/xunit.analyzers/rules/xUnit2030)

Check failure on line 70 in src/Microsoft.Health.Fhir.Shared.Core.UnitTests/Features/Resources/Create/CreateResourceValidatorTests.cs

GitHub Actions / CodeQL-Build (csharp) 

Do not use Assert.NotEmpty to check if a value exists in a collection. Use Assert.Contains instead. (https://xunit.net/xunit.analyzers/rules/xUnit2030)
Assert.NotEmpty(result.Errors.Where(e => e.ErrorMessage.Contains("XHTML content should be contained within a single <div> element")));

Check failure on line 71 in src/Microsoft.Health.Fhir.Shared.Core.UnitTests/Features/Resources/Create/CreateResourceValidatorTests.cs

GitHub Actions / CodeQL-Build (csharp) 

Do not use Assert.NotEmpty to check if a value exists in a collection. Use Assert.Contains instead. (https://xunit.net/xunit.analyzers/rules/xUnit2030)
Assert.NotEmpty(result.Errors.Where(e => e.ErrorMessage.Contains("Id must be any combination of upper or lower case ASCII letters")));

Check failure on line 72 in src/Microsoft.Health.Fhir.Shared.Core.UnitTests/Features/Resources/Create/CreateResourceValidatorTests.cs

GitHub Actions / CodeQL-Build (csharp) 

Do not use Assert.NotEmpty to check if a value exists in a collection. Use Assert.Contains instead. (https://xunit.net/xunit.analyzers/rules/xUnit2030)
}
[InlineData(true, null, true)]
View file
...Shared.Core.UnitTests/Features/Resources/MemberMatch/MemberMatchResourceValidatorTests.cs
var result = validator.Validate(createMemberMatchRequest);
Assert.False(result.IsValid);
Assert.True(result.Errors.Count >= 1);
Assert.NotEmpty(result.Errors.Where(e => e.ErrorMessage.Contains("minimum cardinality 1 cannot be null")));

Check failure on line 58 in src/Microsoft.Health.Fhir.Shared.Core.UnitTests/Features/Resources/MemberMatch/MemberMatchResourceValidatorTests.cs

GitHub Actions / CodeQL-Build (csharp) 

Do not use Assert.NotEmpty to check if a value exists in a collection. Use Assert.Contains instead. (https://xunit.net/xunit.analyzers/rules/xUnit2030)
}
#endif
var result = validator.Validate(createResourceRequest);
Assert.False(result.IsValid);
Assert.True(result.Errors.Count >= 2);
Assert.NotEmpty(result.Errors.Where(e => e.ErrorMessage.Contains("XHTML content should be contained within a single <div> element")));

Check failure on line 97 in src/Microsoft.Health.Fhir.Shared.Core.UnitTests/Features/Resources/MemberMatch/MemberMatchResourceValidatorTests.cs

GitHub Actions / CodeQL-Build (csharp) 

Do not use Assert.NotEmpty to check if a value exists in a collection. Use Assert.Contains instead. (https://xunit.net/xunit.analyzers/rules/xUnit2030)
Assert.NotEmpty(result.Errors.Where(e => e.ErrorMessage.Contains("Id must be any combination of upper or lower case ASCII letters")));

Check failure on line 98 in src/Microsoft.Health.Fhir.Shared.Core.UnitTests/Features/Resources/MemberMatch/MemberMatchResourceValidatorTests.cs

GitHub Actions / CodeQL-Build (csharp) 

Do not use Assert.NotEmpty to check if a value exists in a collection. Use Assert.Contains instead. (https://xunit.net/xunit.analyzers/rules/xUnit2030)
}
[InlineData(true, null, true)]
View file
....Core.UnitTests/Features/Search/SearchParameters/SearchParameterDefinitionManagerTests.cs
Assert.True(patientParams.Where(p => p.Name == "preexisting2").First().IsSearchable);
var questionnaireParams = searchParameterDefinitionManager.GetSearchParameters("QuestionnaireResponse");
Assert.Single(questionnaireParams.Where(p => p.Name == "questionnaire2"));

Check failure on line 548 in src/Microsoft.Health.Fhir.Shared.Core.UnitTests/Features/Search/SearchParameters/SearchParameterDefinitionManagerTests.cs

GitHub Actions / CodeQL-Build (csharp) 

Do not use a Where clause to filter before calling Assert.Single. Use the overload of Assert.Single that accepts a filtering function. (https://xunit.net/xunit.analyzers/rules/xUnit2031)
}
private static void ValidateSearchParam(SearchParameterInfo expectedSearchParam, SearchParameterInfo actualSearchParam)