Verbatim String Fixes#1776
Merged
kevin-montrose merged 4 commits intomainfrom May 8, 2026
Merged
Conversation
… more general fix is needed throughout, but this should fix INFO with large numbers of clients or nodes
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a safer verbatim-string write path to avoid send-buffer edge cases (noted in INFO) and expands tests to cover both RESP2 and RESP3 behaviors.
Changes:
- Parameterize INFO-related tests to run under both RESP2 and RESP3.
- Replace verbatim string writes with a new “large” verbatim writer that flushes safely around buffer boundaries.
- Simplify empty INFO response writes to use
WriteDirect.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| test/Garnet.test/RespInfoTests.cs | Expands INFO tests to run against RESP2 and RESP3 configurations. |
| libs/server/Resp/RespServerSessionOutput.cs | Introduces a new verbatim-string writer that guarantees progress across send-buffer boundaries. |
| libs/server/Resp/ClientCommands.cs | Switches CLIENT LIST/INFO output to use the new large verbatim writer. |
| libs/server/Metrics/Info/InfoCommand.cs | Switches INFO output to use the new large verbatim writer and simplifies empty output path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
badrishc
approved these changes
May 7, 2026
badrishc
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed in in
INFObut generally possible in other cases, we don't always handle response that would fill the send buffer correctly.This fixes all the verbatim string cases (since those are easy to identify) a more general fix is probably necessary.
TODO:
devtargeting branch: [DEV] Verbatim String Fixes #1777