Don't try to override system FIPS mode and use openssl.FIPSCapable #1496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As agreed in https://github.com/microsoft/go-lab/blob/main/docs/adr/0012-remove-gofips.md, we shouldn't try to modify the OpenSSL FIPS mode.
Azure Linux 3 doesn't set
fips=yes
in the default properties, even when running in kernel FIPS mode. They omit it because the default OpenSSL provider, SCOSSL, is already FIPS compliant, and not setting it allows some non-FIPS algorithms to fall back to the built-in provider (which is also enabled by default). This means we can't useopenssl.FIPS()
(which checks iffips=yes
is set) in AZL3. Fortunately we can useopenssl.FIPSCapable()
instead, which doesn't check iffips=yes
is set.This has the nice benefit of being more compliant when running in FIPS mode on AZL3, as more non-FIPS approved algorithms (like SHA1) will be provided by the built-in OpenSSL providers instead of falling back to Go.
For #1445.