-
Notifications
You must be signed in to change notification settings - Fork 50
ByteAddressBuffer Alignment proposal #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ByteAddressBuffer Alignment proposal #557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some editorial changes in the comments. It'd be good to get a sponsor agreed upon before completing the PR, but I think otherwise it looks pretty ready to get merged.
@@ -0,0 +1,982 @@ | |||
# ByteAddressBuffer Alignment | |||
|
|||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
[#258](https://github.com/microsoft/DirectXShaderCompiler/issues/258) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these issues really relevant? 543 seems to be about support continue/break and 258 is a PR incrementing the validator version number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, these issues are in hlsl-specs repo, not DXC.
* Sponsor: TBD | ||
* Status: **Under Consideration** | ||
* Required Version: Shader Model X.Y, Vulkan X.Y, and/or HLSL 20XY | ||
* PRs: [#NNNN](https://github.com/microsoft/DirectXShaderCompiler/pull/NNNN) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* PRs: [#NNNN](https://github.com/microsoft/DirectXShaderCompiler/pull/NNNN) | |
* PRs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Proposes a base alignment attribute for ByteAddressBuffer declarations and new templated Load/Store functions that include a relative alignment argument.