Skip to content

Conversation

mapodaca-nv
Copy link
Contributor

@mapodaca-nv mapodaca-nv commented Jul 14, 2025

Proposes a base alignment attribute for ByteAddressBuffer declarations and new templated Load/Store functions that include a relative alignment argument.

Copy link
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some editorial changes in the comments. It'd be good to get a sponsor agreed upon before completing the PR, but I think otherwise it looks pretty ready to get merged.

@@ -0,0 +1,982 @@
# ByteAddressBuffer Alignment

---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment on lines 12 to 13
[#258](https://github.com/microsoft/DirectXShaderCompiler/issues/258)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these issues really relevant? 543 seems to be about support continue/break and 258 is a PR incrementing the validator version number.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, these issues are in hlsl-specs repo, not DXC.

* Sponsor: TBD
* Status: **Under Consideration**
* Required Version: Shader Model X.Y, Vulkan X.Y, and/or HLSL 20XY
* PRs: [#NNNN](https://github.com/microsoft/DirectXShaderCompiler/pull/NNNN)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* PRs: [#NNNN](https://github.com/microsoft/DirectXShaderCompiler/pull/NNNN)
* PRs:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants