Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i2c reset #21

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

i2c reset #21

wants to merge 1 commit into from

Conversation

jamesadevine
Copy link
Member

Add function definition for i2c_reset

@jamesadevine
i2c reset
5bc7765 
Add function definition for i2c_reset
@jamesadevine jamesadevine mentioned this pull request Apr 13, 2021
Closed
mmoskal
mmoskal reviewed Apr 15, 2021
View reviewed changes
Copy link
Member

@mmoskal mmoskal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems that your current approach with i2c_init calling reset is probably better - no need to expose reset itself?

@jamesadevine jamesadevine marked this pull request as draft April 28, 2021 17:12
@mmoskal
Copy link
Member

mmoskal commented Oct 25, 2021

I found the cause of temp/hum crash - it was not enough time between requesting sensing and reading the i2c. It was due to the jd_next_sample trying to align samples. Fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmoskal mmoskal mmoskal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesadevine @mmoskal