Fix: km config shows entire configuration, not just one node#1094
Merged
dluc merged 2 commits intomicrosoft:mainfrom Nov 28, 2025
Merged
Fix: km config shows entire configuration, not just one node#1094dluc merged 2 commits intomicrosoft:mainfrom
dluc merged 2 commits intomicrosoft:mainfrom
Conversation
Problem: ConfigCommand called Initialize() which forced node selection, making it illogical to show only one node when querying the entire config. Solution: - ConfigCommand now uses GetConfig() directly (no node selection needed) - Default behavior shows all nodes + cache configuration - Added GetConfig() helper method in BaseCommand - Added tests to verify entire config is displayed Changes: - Add ConfigCommandTests with multi-node config verification - Update ConfigCommand to skip Initialize() for config queries - Add BaseCommand.GetConfig() protected method Test results: - Test written first (RED) - verified it failed - Code fixed (GREEN) - test now passes - All 262 tests passing (185 Main + 77 Core) - Zero regressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
km configwas callingInitialize()which forced node selection, making it show only one node instead of the entire configuration.Before:
$ km config { "nodeId": "personal", # Only showed selected node "access": "Full", ... }After:
$ km config { "nodes": [ # Shows ALL nodes { "nodeId": "personal", ... } ], "cache": { # Shows cache config "embeddingsCache": {...} } }Solution
ConfigCommandno longer callsInitialize()(no node selection needed)GetConfig()to access the injected config directly--show-nodesand--show-cacheflags still workTDD Approach
Changes
ConfigCommandTestswith multi-node config verificationConfigCommandto skipInitialize()for config queriesBaseCommand.GetConfig()protected methodTest Results