chore: consolidate code analysis rules and update dependencies#1102
Merged
dluc merged 1 commit intomicrosoft:mainfrom Dec 2, 2025
Merged
chore: consolidate code analysis rules and update dependencies#1102dluc merged 1 commit intomicrosoft:mainfrom
dluc merged 1 commit intomicrosoft:mainfrom
Conversation
- Remove temporary analyzer config files (Core/.editorconfig, GlobalSuppressions.cs) - Consolidate all rules into main .editorconfig with pragmatic severity levels - Update dependencies: Spectre.Console 0.49.1→0.54.0, YamlDotNet 16.2.0→16.3.0 - Fix CLI command signatures for updated Spectre.Console API (add CancellationToken) - Apply code quality fixes (culture-aware string formatting) All tests pass (503/503), coverage 83.82% (threshold 80%)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates code analysis configuration and updates dependencies:
src/Core/.editorconfig,src/Core/GlobalSuppressions.cs).editorconfigwith pragmatic severity levelsCancellationTokenparameter)Changes
Configuration
src/Core/.editorconfigandsrc/Core/GlobalSuppressions.csfilessrc/.editorconfigCA1031(catch general exceptions) - needed for top-level error handlingCA1859(concrete return types) - visitor pattern requires base typesRCS1141(param documentation) - reduced noise during developmentRCS1211(unnecessary else) - style preferenceCA1307/CA1308- intentional string comparison behaviorDependencies
Spectre.Console: 0.49.1 → 0.54.0Spectre.Console.Cli: 0.49.1 → 0.53.1YamlDotNet: 16.2.0 → 16.3.0Code Fixes
CancellationTokenparameter to all CLI commandExecuteAsyncmethods (breaking API change in Spectre.Console)CultureInfo.CurrentCulturetoToString()call inMongoJsonQueryParser.cs:325Test Plan
build.shpasses with 0 warnings/errorsformat.shpassescoverage.shpasses with 83.82% coverage (threshold 80%)Related
Cleanup after #1098 (search command implementation)