Key Update Crash on Allocation Failure #4447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
commented
Aug 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4447 +/- ##
==========================================
- Coverage 87.30% 86.94% -0.36%
==========================================
Files 56 56
Lines 17630 17630
==========================================
- Hits 15391 15328 -63
- Misses 2239 2302 +63 ☔ View full report in Codecov by Sentry. |
anrossi
previously approved these changes
Aug 9, 2024
mtfriesen
approved these changes
Mar 3, 2025
guhetier
reviewed
Mar 3, 2025
|
|
||
| PacketBuffer.push_back(Header.HeaderByte); | ||
| PacketBuffer.insert(PacketBuffer.end(), DestCid.begin(), DestCid.end()); | ||
| PacketBuffer.push_back((uint8_t) (PacketNumber >> 24));// TODO - different packet number sizes |
There was a problem hiding this comment.
nit: Should the todo be addressed now?
guhetier
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While running spinquic locally I hit a crash in the keyupdate scenario where write key failed to allocate and was later tried to be read. This accounts for that edge case now.
Testing
Covered by spinquic. Also added a QuicDrill test.
Documentation
N/A