Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Retry Logic II - Connection Retry #2519

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Jeffery-Wasty
Copy link
Contributor

No description provided.

@Jeffery-Wasty Jeffery-Wasty linked an issue Sep 23, 2024 that may be closed by this pull request
@Jeffery-Wasty Jeffery-Wasty added this to the 12.9.1 milestone Sep 23, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 69.01408% with 22 lines in your changes missing coverage. Please review.

Project coverage is 49.81%. Comparing base (4ec4d3b) to head (2220ba9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...icrosoft/sqlserver/jdbc/ConfigurableRetryRule.java 31.25% 10 Missing and 1 partial ⚠️
...crosoft/sqlserver/jdbc/ConfigurableRetryLogic.java 80.00% 4 Missing and 3 partials ⚠️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 66.66% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2519      +/-   ##
============================================
- Coverage     50.93%   49.81%   -1.13%     
+ Complexity     3886     3795      -91     
============================================
  Files           147      147              
  Lines         33368    33419      +51     
  Branches       5592     5602      +10     
============================================
- Hits          16997    16648     -349     
- Misses        13967    14385     +418     
+ Partials       2404     2386      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jeffery-Wasty Jeffery-Wasty marked this pull request as ready for review November 4, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Under Peer Review
Development

Successfully merging this pull request may close these issues.

Reconnection issue with lockTimeout configured
1 participant