[CHERRY-PICK] Revert Mu Change in Favor of edk2 Change #1305
+0
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202502 #1305 +/- ##
=============================================
Coverage ? 1.59%
=============================================
Files ? 1408
Lines ? 364660
Branches ? 4570
=============================================
Hits ? 5799
Misses ? 358788
Partials ? 73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
apop5
approved these changes
Mar 13, 2025
This reverts commit 1203e4a as it was upstreamed to edk2 as 81031a51a0148a5ff7904f02cc405c8f3b910c55.
apop5
force-pushed
the
2502_basetools_cp
branch
from
a767875 to
f3b7235
Compare
VS2019/VS2022 ARM/AARCH64 is not a widely used toolchain, for one thing edk2 can't be built with it, it will break. Downstream platforms rarely use it and if they do, they must have heavy edits in order to support building edk2. In particular, edk2 does not have support for the assembly files that this toolchain uses fully. As a result, the corresponding StackCheckLib does not have the assembly file needed to satisfy the definitions the compiler expects. Unfortunately, the VS ARM/AARCH64 compiler has a different ABI than the IA32/X64 VS toolchain for stack cookies, so this also needs more investigation. For now, disable stack cookie checking in VS ARM/AARCH64 as this does not affect many platforms. However, it does allow for the use case reported in the bug mentioning this, which is building a shell and attempting to boot to it. When VS ARM/AARCH64 support is revisited in edk2 (or if there is a clean way to add stack cookie support without the full support), this will be revisted. Signed-off-by: Oliver Smith-Denny <[email protected]> (cherry picked from commit 81031a51a0148a5ff7904f02cc405c8f3b910c55)
apop5
force-pushed
the
2502_basetools_cp
branch
from
f3b7235 to
187ad62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Commit 1203e4a was upstreamed to edk2 as 81031a51a0148a5ff7904f02cc405c8f3b910c55.
How This Was Tested
N/A.
Integration Instructions
N/A.