WindowsVsToolChain: Filter vs vars on specific vc #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filters the extra vs vars gathered via QueryVcVariables() to specifically be the ones associated with the vc version set in the same plugin. This is to prevent version of the compiler differing from the version of any included .c / .h files that are made available through the vs vars such as LIB, INCLUDe, etc. Additionally now logs a warning when the plugin detects multiple versions of the compiler in the environment.
github-actions
bot
added
language:python
1 task
makubacki
approved these changes
Mar 19, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202502 #1310 +/- ##
=============================================
Coverage ? 1.59%
=============================================
Files ? 1408
Lines ? 364660
Branches ? 4570
=============================================
Hits ? 5799
Misses ? 358788
Partials ? 73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Filters the extra vs vars gathered via QueryVcVariables() to specifically be the ones associated with the vc version set in the same plugin. This is to prevent version of the compiler differing from the version of any included .c / .h files that are made available through the vs vars such as LIB, INCLUDE, etc.
Additionally, now logs a warning when the plugin detects multiple versions of the compiler in the environment.
Example of log:
How This Was Tested
Validated the WindowsVsToolChain plugin correctly detects and logs when multiple versions of a particular vs toolchain are installed, and that the compiler version match the version of the include paths returned with the vc vars.
Integration Instructions
Consumers of MU_BASECORE must ensure their version of edk2-pytool-extensions is 0.23.1 or greater.