Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typedefs bug with interface circular references #198

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

jasongin
Copy link
Member

@jasongin jasongin commented Feb 3, 2024

Fixes #195

Internal calls to SymbolExtensions.AsType() should pass the generic type parameters (as all other locations in this file do). That overload also defaults to buildType: false, which allows for circular references among types.

@jasongin jasongin requested a review from vmoroz February 3, 2024 03:11
@jasongin
Copy link
Member Author

jasongin commented Feb 3, 2024

This change caused some build errors in some of the tests. I need to investigate further.
Fixed.

@jasongin jasongin merged commit de21e54 into main Feb 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Unable to change after type has been created.' error occurred while publishing NodeJS module
2 participants