Update BiasGelu fusion and related ops #23518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 4 out of 18 changed files in this pull request and generated no comments.
Files not reviewed (14)
- onnxruntime/contrib_ops/cuda/bert/fast_gelu.cc: Language not supported
- onnxruntime/contrib_ops/cuda/cuda_contrib_kernels.cc: Language not supported
- onnxruntime/contrib_ops/rocm/bert/elementwise.h: Language not supported
- onnxruntime/contrib_ops/rocm/bert/elementwise_impl/impl_fastgelu.cu: Language not supported
- onnxruntime/contrib_ops/rocm/bert/elementwise_impl/impl_gelu.cu: Language not supported
- onnxruntime/contrib_ops/rocm/rocm_contrib_kernels.cc: Language not supported
- onnxruntime/core/graph/contrib_ops/bert_defs.cc: Language not supported
- onnxruntime/core/optimizer/bias_gelu_fusion.cc: Language not supported
- onnxruntime/core/providers/cuda/tensor/gelu.cc: Language not supported
- onnxruntime/core/providers/cuda/tensor/gelu_impl.cu: Language not supported
- onnxruntime/test/contrib_ops/fastgelu_op_test.cc: Language not supported
- onnxruntime/test/optimizer/graph_transform_test.cc: Language not supported
- onnxruntime/test/testdata/transform/fusion/bias_onnx_fast_gelu_fusion.onnx: Language not supported
- onnxruntime/test/testdata/transform/fusion/bias_onnx_gelu_fusion.onnx: Language not supported
kunal-vaishnavi
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(1) Update BiasGelu fusion to support onnx Gelu-20
Since onnx Gelu-20 supports float/double/bf16/fp16, here we update related ops to support these data types in CUDA and ROCm execution providers:
(2) Add double support for Gelu/FastGelu op in CUDA/ROCm execution provider
(3) Add BFloat16 support for Gelu ops in CUDA execution provider
(4) Add unit tests
(5) Update operator documents
Motivation and Context
#23491