[WebGPU EP] Batch Norm Implementation #23525
Open
+204
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fs-eire
reviewed
Jan 30, 2025
| spatial_ = info.GetAttrOrDefault<int64_t>("spatial", 1); | ||
| training_mode_ = info.GetAttrOrDefault<int64_t>("training_mode", 0); | ||
| // NCHW for ai.onnx domain, NHWC for com.ms.internal.nhwc domain | ||
| format_ = info.GetAttrOrDefault<std::string>("format", "NHWC"); |
There was a problem hiding this comment.
Does the attribute "format" actually exist?
I think they are introduced in JSEP as a property of the corresponding typescript attribute object, but they are not "real attribute" that you can read from the protobuf.
Also, using string enum is a good practice in TS/JS, but in C++ a numeric type is better choice. For example, the following is defined in onnxruntime namespace:
enum class DataLayout {
NCHW,
NHWC,
NCHWC,
};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases operator coverage for webgpu ep.