Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIGraphX EP] [ROCm EP] Update CI to use ROCm 6.3.2 #23535

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TedThemistokleous
Copy link
Contributor

Description

Update Onnxruntime CI to use latest ROCm release ROCm 6.3.2

Motivation and Context

Ensure CI is testing up to date with recent Onnxruntime. AMD validates changes based off the latest ROCm release and adds additional features on top to validate changes prior to being pushed to our internal testing branches and then up streamed to Microsoft/Onnxruntime:main . Right now Onnxruntime is testing things a few releases back for their CI

@snnn
Copy link
Member

snnn commented Jan 29, 2025

/azp run Big Models, Linux Android Emulator QNN CI Pipeline, Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline

@snnn
Copy link
Member

snnn commented Jan 29, 2025

/azp run Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows CPU CI Pipeline,

@snnn
Copy link
Member

snnn commented Jan 29, 2025

/azp run Windows GPU CUDA CI Pipeline, Windows GPU DML CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows x64 QNN CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline

Copy link

Azure Pipelines successfully started running 6 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@snnn
Copy link
Member

snnn commented Jan 29, 2025

/azp run Linux MIGraphX CI Pipeline

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TedThemistokleous TedThemistokleous changed the title Update CI to use ROCm 6.3.2 [MIGraphX EP] [ROCm EP] Update CI to use ROCm 6.3.2 Jan 29, 2025
@tianleiwu
Copy link
Contributor

tianleiwu commented Jan 29, 2025

Need change the pipeline configuration:

- name: RocmVersion
value: 6.2
- name: RocmVersionPatchSuffix
value: ".3"

Note that ROCm EP uses another docker file and yml file. It is fine to only upgrade MigraphX CI in this PR.

@TedThemistokleous
Copy link
Contributor Author

Need change the pipeline configuration:

- name: RocmVersion
value: 6.2
- name: RocmVersionPatchSuffix
value: ".3"

Note that ROCm EP uses another docker file and yml file. It is fine to only upgrade MigraphX CI in this PR.

Updated

@snnn
Copy link
Member

snnn commented Jan 29, 2025

/azp run Big Models, Linux Android Emulator QNN CI Pipeline, Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline

@snnn
Copy link
Member

snnn commented Jan 29, 2025

/azp run Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows CPU CI Pipeline,

@snnn
Copy link
Member

snnn commented Jan 29, 2025

/azp run Windows GPU CUDA CI Pipeline, Windows GPU DML CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows x64 QNN CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline

@snnn
Copy link
Member

snnn commented Jan 29, 2025

/azp run Linux MIGraphX CI Pipeline

Copy link

Azure Pipelines successfully started running 6 pipeline(s).

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

Azure Pipelines successfully started running 6 pipeline(s).

Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@tianleiwu
Copy link
Contributor

/azp run Linux ROCm CI Pipeline

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tianleiwu
Copy link
Contributor

tianleiwu commented Jan 29, 2025

@TedThemistokleous, The ROCm CI Pipeline failed. It is because cupy does not support ROCm 6.3 yet. I think the solution is to remove cupy from the docker file, then set an environment variable KERNEL_EXPLORER_TEST_USE_CUPY=0. See the usage of cupy in test:

if os.getenv("KERNEL_EXPLORER_TEST_USE_CUPY", "0") == "1":
import cupy as cp

Updated: It is a little complicated so I sent a PR to update ROCm CI: #23542.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants