[web] remove the unhelpful "Unknown CPU vendor" warning.#27399
Open
[web] remove the unhelpful "Unknown CPU vendor" warning.#27399
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the confusing "Unknown CPU vendor" warning for WebAssembly builds where CPU information is intentionally not exposed in browser environments.
Changes:
- Skip VendorInfoInit() call on WebAssembly platforms to avoid the warning
- Initialize vendor_id_ to 0 to ensure proper default value when VendorInfoInit is not called
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| onnxruntime/core/common/cpuid_info.h | Add explicit initialization of vendor_id_ to 0 to ensure defined behavior on WebAssembly |
| onnxruntime/core/common/cpuid_info.cc | Conditionally skip VendorInfoInit() on wasm builds to prevent warning about unknown CPU vendor |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
remove the "Unknown CPU vendor" warning for webassembly.
CPU info is not supposed to expose in a browser environment, so it is expected to have no CPU info at runtime. Disable the confusing warning message for WebAssembly.
Motivation and Context
fixes #27336