Skip to content

nvme_test: mirror nvme architecture to support multiple submission queues per completion queue #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

nvme_test: mirror nvme architecture to support multiple submission queues per completion queue #2026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b72c2c
Initial plan
Copilot Sep 18, 2025
14c0fd5
Remove completion queue sharing restriction and update SubmissionQueu…
Copilot Sep 19, 2025
2ff9c9c
Implement support for multiple submission queues per completion queue
Copilot Sep 19, 2025
d2d3990
Merge branch 'main' into copilot/fix-2025
gurasinghMS Sep 19, 2025
710900e
Complete nvme_test architecture update to support multiple submission…
Copilot Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4880,6 +4880,7 @@ dependencies = [
"pci_core",
"pci_resources",
"scsi_buffers",
"slab",
"task_control",
"thiserror 2.0.16",
"tracelimit",
Expand Down
1 change: 1 addition & 0 deletions vm/devices/storage/nvme_test/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ async-trait.workspace = true
futures.workspace = true
futures-concurrency.workspace = true
parking_lot.workspace = true
slab.workspace = true
task_control.workspace = true
thiserror.workspace = true
tracelimit.workspace = true
Expand Down
10 changes: 3 additions & 7 deletions vm/devices/storage/nvme_test/src/queue.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,13 +252,9 @@ pub enum QueueError {
}

impl SubmissionQueue {
pub fn new(
doorbells: Arc<RwLock<DoorbellMemory>>,
db_id: u16,
gpa: u64,
len: u16,
mem: GuestMemory,
) -> Self {
pub fn new(cq: &CompletionQueue, db_id: u16, gpa: u64, len: u16) -> Self {
let doorbells = cq.head.doorbells.clone();
let mem = cq.mem.clone();
doorbells.read().write(db_id, 0);
Self {
tail: DoorbellState::new(doorbells, db_id, len.into()),
Expand Down
Loading