firmware_uefi: EfiDiagnostics adjust trace channel handling #2054
+64
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… get sent to correct trace channels regardless of exact match
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts UEFI diagnostics log handling to use bitwise operations for trace channel selection, allowing logs containing ERROR or WARNING flags to route to appropriate trace levels instead of requiring exact matches.
- Changed from exact debug level matching to bitwise flag checking for ERROR and WARNING
- Moved string conversion logic from handler functions to the processing function
- Updated function signatures to pass both processed log structs and raw debug levels
smalis-msft
previously approved these changes
Oct 6, 2025
maheeraeron
changed the title
smalis-msft
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simply adjusts it so that UEFI logs that contain ERROR or WARNING get sent to the tracing::error!() or tracing::warn!() channels respectively. This is different from the current behavior, where logs that are EXACTLY ERROR or WARNING would only get sent to the respective trace macros.
It also moves the string conversion logic to the processing function.