Skip to content

Conversation

smalis-msft
Copy link
Contributor

Let's see if this is still an issue.

@smalis-msft smalis-msft requested a review from a team as a code owner October 3, 2025 16:57
@Copilot Copilot AI review requested due to automatic review settings October 3, 2025 16:57
@smalis-msft smalis-msft added the release-ci-required Add to a PR to trigger PR gates in release mode label Oct 3, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes a temporary workaround that added a 1-second timeout override for Windows unit tests in CI. The change eliminates the Windows-specific timeout configuration that was addressing random test stalls in release mode.

  • Removes the temporary Windows unit test timeout configuration
  • Eliminates the associated comment explaining the workaround
  • Simplifies the nextest configuration by removing the platform-specific override
Comments suppressed due to low confidence (1)

.config/nextest.toml:1

  • Corrected spelling of 'occationally' to 'occasionally'.
# Copyright (c) Microsoft Corporation.

Copy link

github-actions bot commented Oct 3, 2025

@smalis-msft smalis-msft enabled auto-merge (squash) October 3, 2025 20:47
@smalis-msft
Copy link
Contributor Author

Ran things twice, seems ok?

@mattkur mattkur disabled auto-merge October 4, 2025 20:55
Copy link
Contributor

@mattkur mattkur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we'll have to see just how occasionally this hit. I disabled your auto-merge to make sure this went in during business hours (just in case this ends up affecting CI reliability).

@smalis-msft smalis-msft merged commit 31f9767 into microsoft:main Oct 6, 2025
133 of 138 checks passed
@smalis-msft smalis-msft deleted the windows-unit-tests-nextest branch October 6, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-ci-required Add to a PR to trigger PR gates in release mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants