vmm_tests: More multiarch cleanups #2078
Merged
+107
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR performs multiarch test cleanup by removing tests that don't cover project code, enabling previously commented tests, and improving test organization. The changes focus on removing Hyper-V tests without OpenHCL, consolidating duplicated tests, and adding NUMA node configuration to heavy tests.
Key changes:
- Removed Hyper-V tests without OpenHCL from the frontpage test
- Re-enabled previously commented TDX tests and added missing test configurations
- Added NUMA topology configuration (vps_per_socket: Some(8)) to heavy test scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vmm_tests/vmm_tests/tests/tests/multiarch.rs | Main test cleanup including removal of non-OpenHCL tests, re-enabling TDX tests, adding NUMA configuration, and reorganizing test functions |
| vmm_tests/vmm_tests/tests/tests/multiarch/vmbus_relay.rs | Added NUMA topology configuration to heavy vmbus relay test |
smalis-msft
commented
Oct 4, 2025
auto-merge was automatically disabled
October 4, 2025 01:08
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove tests that don't actually cover any of our code (hyper-v without openhcl),
try uncommenting tests to see if they're still broken, move more tests to use pipette, add numa node configuration to heavy tests, remove some duplicated testing, and ensure nothing's missing.