vmgs: dont upgrade vmgs encryption on auto and allow fallback for gspkey #2368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ft#2055) When strict encryption policy is not enabled, allow the HCL to GspById if GspKey is not available.
To prevent unintentional migration of VMGS encryption methods, disable higher encryption sources when encryption policy is configured to Auto and the VMGS has already been provisioned.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prevents unintended encryption changes to VMGS (VM Guest State) files when using the Auto encryption policy. It adds tracking to determine if a VMGS file was provisioned during the current boot and uses this information to preserve existing encryption state unless explicitly requested.
Key changes:
- Added
provisioned_this_boottracking to VMGS to distinguish between newly provisioned and pre-existing guest state - Updated
Autoencryption policy to preserve existing encryption method instead of migrating to different schemes - Refined
GspKeyencryption policy to allow fallback toGspByIdwhen strict policy is disabled
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vm/vmgs/vmgs/src/vmgs_impl.rs | Adds provisioned_this_boot field and getter method to track if VMGS was formatted during current boot |
| vm/devices/get/get_protocol/src/dps_json.rs | Updates documentation to clarify that Auto policy no longer migrates encryption and GspKey policy allows fallback |
| openhcl/underhill_attestation/src/lib.rs | Implements logic to prevent encryption changes under Auto policy for existing unencrypted or GspById-encrypted guest state |
Comments suppressed due to low confidence (1)
vm/devices/get/get_protocol/src/dps_json.rs:123
- Corrected spelling of 'Exisiting' to 'Existing'.
/// if it is available. Exisiting GspKey encryption will be used unless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry picks of:
#2055 allow fallback from GspKey to GspById
When strict encryption policy is not enabled, allow the HCL to GspById if GspKey is not available.
#2280 dont upgrade vmgs encryption on auto
To prevent unintentional migration of VMGS encryption methods, disable higher encryption sources when encryption policy is configured to Auto and the VMGS has already been provisioned.