1.8: flowey: Fail with a non-zero exit code when local vmm test runs fail (#3956) - #4115
Open
smalis-msft wants to merge 1 commit into
Open
1.8: flowey: Fail with a non-zero exit code when local vmm test runs fail (#3956)#4115smalis-msft wants to merge 1 commit into
smalis-msft wants to merge 1 commit into
Conversation
…icrosoft#3956) Easy fix, but makes it easier to detect failures from scripts. (cherry picked from commit 5e8dfd1)
Contributor
There was a problem hiding this comment.
Pull request overview
This backport changes Flowey’s local “build and run nextest VMM tests” job to return an error when the test run reports failures, ensuring callers (including scripts) observe a non-zero exit status rather than a successful completion with only a logged error.
Changes:
- Convert the “test failures encountered” path from
log::error!toanyhow::bail!, causing the step/job to fail whenresults.all_tests_passedis false.
smalis-msft
enabled auto-merge (squash)
July 31, 2026 17:20
mattkur
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3956 to
release/1.8.2607.The cherry-pick of 5e8dfd1 applied cleanly onto
release/1.8.2607with no conflicts and no manual edits.Original PR: #3956
This backport PR was created by an AI agent (GitHub Copilot) on behalf of @smalis-msft.