Skip to content

Fix ulong/uint/ushort event properties displayed as signed types in event viewer #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix ulong/uint/ushort event properties displayed as signed types in event viewer #2313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69e6f87
Initial plan
Copilot Oct 9, 2025
c3d1172
Fix ulong/uint/ushort display in event viewer by using unsigned types
Copilot Oct 10, 2025
ece67dd
Update test baselines.
brianrob Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/TraceEvent/DynamicTraceEventParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1353,7 +1353,6 @@ public PayloadFetch(ushort offset, RegisteredTraceEventParser.TdhInputType inTyp
Size = 1;
break;
case RegisteredTraceEventParser.TdhInputType.Int16:
case RegisteredTraceEventParser.TdhInputType.UInt16:
Size = 2;
if (outType == 1) // Encoding for String
{
Expand All @@ -1362,18 +1361,33 @@ public PayloadFetch(ushort offset, RegisteredTraceEventParser.TdhInputType inTyp
}
Type = typeof(short);
break;
case RegisteredTraceEventParser.TdhInputType.UInt16:
Size = 2;
if (outType == 1) // Encoding for String
{
Type = typeof(char);
break;
}
Type = typeof(ushort);
break;
case RegisteredTraceEventParser.TdhInputType.Int32:
case RegisteredTraceEventParser.TdhInputType.UInt32:
case RegisteredTraceEventParser.TdhInputType.HexInt32:
Type = typeof(int);
Size = 4;
break;
case RegisteredTraceEventParser.TdhInputType.UInt32:
Type = typeof(uint);
Size = 4;
break;
case RegisteredTraceEventParser.TdhInputType.Int64:
case RegisteredTraceEventParser.TdhInputType.UInt64:
case RegisteredTraceEventParser.TdhInputType.HexInt64:
Type = typeof(long);
Size = 8;
break;
case RegisteredTraceEventParser.TdhInputType.UInt64:
Type = typeof(ulong);
Size = 8;
break;
case RegisteredTraceEventParser.TdhInputType.Float:
Type = typeof(float);
Size = 4;
Expand Down
2 changes: 1 addition & 1 deletion ...ent/TraceEvent.Tests/inputs/eventpipe-dotnetcore3.0-win-x64-objver4.nettrace.baseline.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Microsoft-Windows-DotNETRuntime/AppDomainResourceManagement/ThreadCreated, 14, <Event MSec= "17.8861" PID="10064" PName="Process(10064)" TID="3444" EventName="AppDomainResourceManagement/ThreadCreated" ManagedThreadID="0x0000019A7A321810" AppDomainID="0x0000019A783A12A0" Flags="0x00000000" ManagedThreadIndex="3" OSThreadID="3,444" ClrInstanceID="3"/>
Microsoft-Windows-DotNETRuntime/Contention/Start, 8, <Event MSec= "3098.9569" PID="10064" PName="Process(10064)" TID="12248" EventName="Contention/Start" ContentionFlags="Managed" ClrInstanceID="3" LockID="0x00000000" AssociatedObjectID="0x00000000" LockOwnerThreadID="0"/>
Microsoft-Windows-DotNETRuntime/Contention/Stop, 8, <Event MSec= "3235.9560" PID="10064" PName="Process(10064)" TID="12272" EventName="Contention/Stop" ContentionFlags="Managed" ClrInstanceID="3" DurationNs="137400255.241591"/>
Microsoft-Windows-DotNETRuntime/GC, 16, <Event MSec= "1598.5796" PID="10064" PName="Process(10064)" TID="7532" EventName="GC" ProviderName="Microsoft-Windows-DotNETRuntime" FormattedMessage="BytesAllocated=3,784;\r\n;\r\nClrInstanceID=3 " BytesAllocated="3,784" ClrInstanceID="3"/>
Microsoft-Windows-DotNETRuntime/GC, 16, <Event MSec= "1598.5796" PID="10064" PName="Process(10064)" TID="7532" EventName="GC" ProviderName="Microsoft-Windows-DotNETRuntime" FormattedMessage="BytesAllocated=0x00000ec8;\r\n;\r\nClrInstanceID=3 " BytesAllocated="0x00000ec8" ClrInstanceID="3"/>
Microsoft-Windows-DotNETRuntime/GC/AllocationTick, 35458, <Event MSec= "2331.8048" PID="10064" PName="Process(10064)" TID="6920" EventName="GC/AllocationTick" AllocationAmount="0x000196A0" AllocationKind="Small" ClrInstanceID="3" AllocationAmount64="104,096" TypeID="0x00007FFEA911EA28" TypeName="System.Object[]" HeapIndex="0" Address="0x0000019A00017FE8"/>
Microsoft-Windows-DotNETRuntime/GC/BulkMovedObjectRanges, 478, <Event MSec= "5470.4377" PID="10064" PName="Process(10064)" TID="12272" EventName="GC/BulkMovedObjectRanges" Index="0" Count="142" ClrInstanceID="3">\r\n <GCBulkMovedObjectRangesValues OldRangeBase="0x0000019A00001048" NewRangeBase="0x0000019A00001048" RangeLength="0x00000330"/>\r\n <GCBulkMovedObjectRangesValues OldRangeBase="0x0000019A00001378" NewRangeBase="0x0000019A00001378" RangeLength="0x000000C0"/>\r\n <GCBulkMovedObjectRangesValues OldRangeBase="0x0000019A00001498" NewRangeBase="0x0000019A00001438" RangeLength="0x00000028"/>\r\n <GCBulkMovedObjectRangesValues OldRangeBase="0x0000019A000014E0" NewRangeBase="0x0000019A00001460" RangeLength="0x00000028"/>\r\n <GCBulkMovedObjectRangesValues OldRangeBase="0x0000019A00001528" NewRangeBase="0x0000019A00001488" RangeLength="0x000003B0"/>\r\n <GCBulkMovedObjectRangesValues OldRangeBase="0x0000019A000019A0" NewRangeBase="0x0000019A00001850" RangeLength="0x00000110"/>\r\n <GCBulkMovedObjectRangesValues OldRangeBase="0x0000019A000
Microsoft-Windows-DotNETRuntime/GC/FinalizersStart, 2, <Event MSec= "5476.2263" PID="10064" PName="Process(10064)" TID="11488" EventName="GC/FinalizersStart" ClrInstanceID="3"/>
Expand Down
8 changes: 4 additions & 4 deletions src/TraceEvent/TraceEvent.Tests/inputs/net.4.5.2.x64.baseline.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ EVENT 2,250.254: Windows Kernel/DiskIO/FlushInit PID=944; TID=960; PName=svchost
EVENT 2,328.938: Windows Kernel/DiskIO/FlushBuffers PID=-1; TID=786839; PName=; ProceNum=5; DataLen=28; DiskNumber=0; IrpFlags=None; Irp=0xfffffa83017ffb80; ElapsedTimeMSec=78.684;
EVENT 2,656.537: Windows Kernel/Thread/Start PID=1632; TID=3664; PName=MsMpEng; ProceNum=1; DataLen=72; StackBase=0xfffff88005efc000; StackLimit=0xfffff88005ef6000; UserStackBase=0x9911c50000; UserStackLimit=0x9911c4b000; StartAddr=0x000000ff; Win32StartAddr=0x7f9cd5ab364; TebBase=0x7f7898ec000; SubProcessTag=142; BasePriority=8; PagePriority=5; IoPriority=2; ThreadFlags=0; ThreadName=; ParentThreadID=3,960; ParentProcessID=1,632;
EVENT 2,733.175: KernelTraceControl/MetaData/EventMapInfo PID=3508; TID=3512; PName=cmd; ProceNum=7; DataLen=96;
EVENT 2,733.175: Microsoft-Windows-Kernel-Process/ProcessStart/Start PID=3508; TID=3512; PName=cmd; ProceNum=7; DataLen=182; ProcessID=3,676; CreateTime=20/07/29 00:07:03.35...; ParentProcessID=3,508; SessionID=1; Flags=0; ImageName=\Device\Mup\clrmain\...;
EVENT 2,733.175: Microsoft-Windows-Kernel-Process/ProcessStart/Start PID=3508; TID=3512; PName=cmd; ProceNum=7; DataLen=182; ProcessID=3676; CreateTime=20/07/29 00:07:03.35...; ParentProcessID=3508; SessionID=1; Flags=0; ImageName=\Device\Mup\clrmain\...;
EVENT 2,733.176: Windows Kernel/Process/Start PID=3676; TID=-1; PName=Test.x64; ProceNum=7; DataLen=123; ProcessID=3,676; ParentID=3,508; ImageFileName=Test.x64.exe; PageDirectoryBase=0x558fb000; Flags=None; SessionID=1; ExitStatus=259; UniqueProcessKey=0xfffffa8300cfb380; CommandLine=Test.x64.exe; PackageFullName=; ApplicationID=;
EVENT 2,733.245: Windows Kernel/Thread/Start PID=3676; TID=3680; PName=Test.x64; ProceNum=7; DataLen=72; StackBase=0xfffff88006daa000; StackLimit=0xfffff88006da4000; UserStackBase=0x00690000; UserStackLimit=0x0068f000; StartAddr=0x000000ff; Win32StartAddr=0x0055287a; TebBase=0x7f5ff23e000; SubProcessTag=0; BasePriority=8; PagePriority=5; IoPriority=2; ThreadFlags=0; ThreadName=; ParentThreadID=3,512; ParentProcessID=3,508;
EVENT 2,734.075: Microsoft-Windows-Kernel-EventTracing/ETW_TASK_PROVIDER/ETW_OPCODE_REGISTER PID=3508; TID=3512; PName=cmd; ProceNum=7; DataLen=16; ProviderName=eef54e71-0661-422d-9...;
Expand Down Expand Up @@ -233,7 +233,7 @@ EVENT 3,079.916: Microsoft-Windows-DotNETRuntime/Loader/DomainModuleLoad PID=367
EVENT 3,079.921: Microsoft-Windows-DotNETRuntimePrivate/Binding/LoaderDeliverEventsPhaseStop PID=3676; TID=3680; PName=Test.x64; ProceNum=7; DataLen=38; AppDomainID=1; LoadContextID=4; FromLoaderCache=0; DynamicLoad=0; AssemblyCodebase=NULL; AssemblyName=Test; ClrInstanceID=9;
EVENT 3,110.112: Microsoft-Windows-DotNETRuntimePrivate/Binding/LoaderPhaseStart PID=3676; TID=3680; PName=Test.x64; ProceNum=7; DataLen=38; AppDomainID=1; LoadContextID=4; FromLoaderCache=0; DynamicLoad=0; AssemblyCodebase=NULL; AssemblyName=NULL; ClrInstanceID=9;
EVENT 3,110.122: Microsoft-Windows-DotNETRuntimePrivate/Binding/LoaderPhaseStop PID=3676; TID=3680; PName=Test.x64; ProceNum=7; DataLen=46; AppDomainID=1; LoadContextID=4; FromLoaderCache=0; DynamicLoad=0; AssemblyCodebase=NULL; AssemblyName=mscorlib; ClrInstanceID=9;
EVENT 3,120.929: Microsoft-Windows-DotNETRuntime/GarbageCollection/IncreaseMemoryPressure PID=3676; TID=3680; PName=Test.x64; ProceNum=7; DataLen=10; BytesAllocated=1,936; ClrInstanceID=9;
EVENT 3,120.929: Microsoft-Windows-DotNETRuntime/GarbageCollection/IncreaseMemoryPressure PID=3676; TID=3680; PName=Test.x64; ProceNum=7; DataLen=10; BytesAllocated=0x00000790; ClrInstanceID=9;
EVENT 3,210.316: Microsoft-Windows-DotNETRuntime/GC/AllocationTick PID=3676; TID=3680; PName=Test.x64; ProceNum=7; DataLen=66; AllocationAmount=102,760; AllocationKind=Small; ClrInstanceID=9; AllocationAmount64=102,760; TypeID=0x7f95eab6088; TypeName=System.Object; HeapIndex=0; Address=0x02567fc8; ObjectSize=0;
EVENT 3,210.813: Microsoft-Windows-DotNETRuntime/GC/AllocationTick PID=3676; TID=3680; PName=Test.x64; ProceNum=7; DataLen=66; AllocationAmount=106,912; AllocationKind=Small; ClrInstanceID=9; AllocationAmount64=106,912; TypeID=0x7f95eab6088; TypeName=System.Object; HeapIndex=0; Address=0x02581fc8; ObjectSize=0;
EVENT 3,211.301: Microsoft-Windows-DotNETRuntime/GC/AllocationTick PID=3676; TID=3680; PName=Test.x64; ProceNum=7; DataLen=66; AllocationAmount=106,912; AllocationKind=Small; ClrInstanceID=9; AllocationAmount64=106,912; TypeID=0x7f95eab6088; TypeName=System.Object; HeapIndex=0; Address=0x0259bfc8; ObjectSize=0;
Expand Down Expand Up @@ -378,7 +378,7 @@ EVENT 8,201.576: Microsoft-Windows-DotNETRuntime/Loader/ModuleUnload PID=3676; T
EVENT 8,201.596: Microsoft-Windows-DotNETRuntime/Loader/AssemblyUnload PID=3676; TID=3680; PName=Test.x64; ProceNum=7; DataLen=182; AssemblyID=7,884,224; AppDomainID=8,769,226,034,224; AssemblyFlags=DomainNeutral; FullyQualifiedAssemblyName=mscorlib, Version=4....; BindingID=0; ClrInstanceID=9;
EVENT 8,201.600: Microsoft-Windows-DotNETRuntime/Loader/AppDomainUnload PID=3676; TID=3680; PName=Test.x64; ProceNum=7; DataLen=44; AppDomainID=8,769,226,034,224; AppDomainFlags=Shared; AppDomainName=SharedDomain; AppDomainIndex=0; ClrInstanceID=9;
EVENT 8,202.277: Windows Kernel/Process/PerfCtr PID=3676; TID=-1; PName=Test.x64; ProceNum=7; DataLen=104; ProcessID=3,676; MemoryCount=0; HandleCount=0; PeakVirtualSize=492,675,072; PeakWorkingSetSize=18,219,008; PeakPagefileUsage=10,784,768; QuotaPeakPagedPoolUsage=145,520; QuotaPeakNonPagedPoolUsage=26,752; VirtualSize=0; WorkingSetSize=0; PagefileUsage=0; QuotaPagedPoolUsage=0; QuotaNonPagedPoolUsage=0; PrivatePageCount=0;
EVENT 8,202.284: Microsoft-Windows-Kernel-Process/ProcessStop/Stop PID=3676; TID=3680; PName=Test.x64; ProceNum=7; DataLen=89; ProcessID=3,676; CreateTime=20/07/29 00:07:03.35...; ExitTime=20/07/29 00:07:08.82...; ExitCode=0; TokenElevationType=2; HandleCount=101; CommitCharge=10,559,488; CommitPeak=10,784,768; CPUCycleCount=18,544,501,267; ReadOperationCount=6; WriteOperationCount=3; ReadTransferKiloBytes=25; WriteTransferKiloBytes=0; HardFaultCount=145; ImageName=Test.x64.exe;
EVENT 8,202.284: Microsoft-Windows-Kernel-Process/ProcessStop/Stop PID=3676; TID=3680; PName=Test.x64; ProceNum=7; DataLen=89; ProcessID=3676; CreateTime=20/07/29 00:07:03.35...; ExitTime=20/07/29 00:07:08.82...; ExitCode=0; TokenElevationType=2; HandleCount=101; CommitCharge=0x00a12000; CommitPeak=0x00a49000; CPUCycleCount=0x45156a213; ReadOperationCount=6; WriteOperationCount=3; ReadTransferKiloBytes=25; WriteTransferKiloBytes=0; HardFaultCount=145; ImageName=Test.x64.exe;
EVENT 8,202.285: Windows Kernel/Process/Stop PID=3676; TID=-1; PName=Test.x64; ProceNum=7; DataLen=123; ProcessID=3,676; ParentID=3,508; ImageFileName=Test.x64.exe; PageDirectoryBase=0x558fb000; Flags=None; SessionID=1; ExitStatus=0; UniqueProcessKey=0xfffffa8300cfb380; CommandLine=Test.x64.exe; PackageFullName=; ApplicationID=;
EVENT 9,772.576: Windows Kernel/DiskIO/FlushInit PID=4; TID=44; PName=System; ProceNum=5; DataLen=12; Irp=0xfffffa8302a1dc60;
EVENT 9,882.352: Windows Kernel/DiskIO/FlushBuffers PID=-1; TID=1097765; PName=; ProceNum=5; DataLen=28; DiskNumber=0; IrpFlags=None; Irp=0xfffffa8302a1dc60; ElapsedTimeMSec=109.777;
Expand All @@ -397,7 +397,7 @@ EVENT 9,902.552: System.Threading.Tasks.TplEventSource/TaskExecute/Start PID=398
EVENT 9,903.079: System.Threading.Tasks.TplEventSource/TaskExecute/Start PID=3988; TID=3780; PName=PerfView; ProceNum=3; DataLen=12; OriginatingTaskSchedulerID=1; OriginatingTaskID=5; TaskID=8;
EVENT 9,903.146: System.Diagnostics.Eventing.FrameworkEventSource/ThreadPoolDequeueWork PID=3988; TID=3672; PName=PerfView; ProceNum=7; DataLen=8; workID=278,775,344;
EVENT 9,903.165: System.Threading.Tasks.TplEventSource/TaskExecute/Start PID=3988; TID=3672; PName=PerfView; ProceNum=7; DataLen=12; OriginatingTaskSchedulerID=1; OriginatingTaskID=0; TaskID=7;
EVENT 9,903.179: Microsoft-Windows-DotNETRuntime/GarbageCollection/IncreaseMemoryPressure PID=3988; TID=3672; PName=PerfView; ProceNum=7; DataLen=10; BytesAllocated=1,328; ClrInstanceID=11;
EVENT 9,903.179: Microsoft-Windows-DotNETRuntime/GarbageCollection/IncreaseMemoryPressure PID=3988; TID=3672; PName=PerfView; ProceNum=7; DataLen=10; BytesAllocated=0x00000530; ClrInstanceID=11;
EVENT 9,903.345: Microsoft-Windows-DotNETRuntime/Exception/Start PID=3988; TID=3780; PName=PerfView; ProceNum=3; DataLen=170; ExceptionType=System.IO.FileNotFou...; ExceptionMessage=The session PerfView...; ExceptionEIP=0x0a3910f0; ExceptionHRESULT=-2,147,024,894; ExceptionFlags=CLSCompliant; ClrInstanceID=11;
EVENT 9,903.405: Microsoft-Windows-DotNETRuntime/ThreadPoolWorkerThread/Start PID=3988; TID=1944; PName=PerfView; ProceNum=4; DataLen=10; ActiveWorkerThreadCount=5; RetiredWorkerThreadCount=0; ClrInstanceID=11;
EVENT 9,903.425: System.Threading.Tasks.TplEventSource/TaskExecute/Stop PID=3988; TID=3780; PName=PerfView; ProceNum=3; DataLen=16; OriginatingTaskSchedulerID=1; OriginatingTaskID=5; TaskID=8; IsExceptional=False;
Expand Down
Loading