Skip to content

Refactor PEFile and PEHeader to use ReadOnlySpan exclusively with zero-copy buffer sharing #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
+2,259 −124
Open

Refactor PEFile and PEHeader to use ReadOnlySpan exclusively with zero-copy buffer sharing #2317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
78c2cb5
Initial plan
Copilot Oct 10, 2025
bd267a9
Convert PEFile and PEHeader to use ReadOnlySpan for bounds checking
Copilot Oct 10, 2025
675ff78
Eliminate buffer copy in PEHeader by using shared buffer reference
Copilot Oct 10, 2025
6026d57
Refactor based on review feedback: PEBufferedSlice struct, rename to …
Copilot Oct 10, 2025
2f6476d
Remove dual-path implementation, use only span-based approach through…
Copilot Oct 10, 2025
fd344b1
Add comprehensive PEFile tests to validate span-based implementation
Copilot Oct 10, 2025
fe420c0
Fix file deletion issue in PEFile_InvalidFileThrowsException test
Copilot Oct 13, 2025
ff06902
Add exponential backoff and comparison test between old and new PEFil…
Copilot Oct 13, 2025
e41e449
Remove flakey test that just ensures non-PE fails.
brianrob Oct 13, 2025
de5fab3
Refactor comparison tests and remove timestamp test per review feedback
Copilot Oct 14, 2025
b00ebf4
Make native binary test fail instead of skip when kernel32.dll not found
Copilot Oct 14, 2025
1031ef0
Remove unnecessary header offset validation checks per review feedback
Copilot Oct 14, 2025
e0b7361
Fix PEHeader constructor to allow reading larger headers progressively
Copilot Oct 16, 2025
d46532d
Remove validation that span contains sections offset - allow progress…
Copilot Oct 17, 2025
fb99913
Add clarifying comments about progressive read pattern and bounds che…
Copilot Oct 17, 2025
c99640b
Clean-up constants.
brianrob Oct 18, 2025
d11501f
Add test application demonstrating large PE header support
Copilot Nov 10, 2025
e68bfc1
Update standalone test.
brianrob Nov 10, 2025
a04994b
Generate PE with imageHeaderOffset=520 (>512) to trigger old implemen…
Copilot Nov 10, 2025
4f05a4f
Remove TestApps
brianrob Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading