-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added css assertion support #35110
base: main
Are you sure you want to change the base?
Added css assertion support #35110
Conversation
Test results for "tests 1"3 flaky38667 passed, 803 skipped Merge workflow run. |
Lint does not pass because of code formatting. # this should pass with no error
npm run lint
# try this
npm run lint -- --fix Please check the contributor guide https://github.com/microsoft/playwright/blob/main/CONTRIBUTING.md Is there an existing issue to discuss this change ? I feel this contribution falls in this category:
|
@vaibhrez12 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
feat: Added support for css assertion for any element
Overview
This PR implements the feature to add assertion for css properties for any UI element using codegen recorder. Below the feature request issue handled in this PR - https://github.com/microsoft/playwright/issues/35113
Feature
Record the css property assertion using codegen. Recorder will show the following css properties with value by default in dialog box
{ "background-color":"rgb(172, 227, 230)", "font-style":"600 18px / 24px OpenSans, \"Segoe UI\", SegoeUI, \"Helvetica Neue\", Helvetica, Arial, sans-serif", "font-size":"18px" }
User can update the default properties value expected and also add additional properties in same format as below
{ "background-color":"rgb(172, 227, 230)", "font-style":"600 18px / 24px OpenSans, \"Segoe UI\", SegoeUI, \"Helvetica Neue\", Helvetica, Arial, sans-serif", "font-size":"18px", "text-align":"left" }
Benefits
This will help in recording css property assertions for UI elements using codegen.