Skip to content

Conversation

hbenl
Copy link
Contributor

@hbenl hbenl commented Aug 26, 2025

Fixes the following tests:

  • tests/page/page-request-fulfill.spec.ts:
    • "should allow mocking binary responses"
    • "should allow mocking svg with charset"
  • tests/library/screenshot.spec.ts:
    • "element screenshot should work with a mobile viewport"
    • "element screenshot should work with device scale factor"

Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › reporter-html.spec.ts:1037 › merged › should have link for opening HTML attachments in new tab @macos-latest-node18-2

2 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-event-request.spec.ts:182 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node18`

33896 passed, 636 skipped


Merge workflow run.

@whimboo
Copy link
Collaborator

whimboo commented Aug 26, 2025

@hbenl, don't we also miss the firefox equivalent under tests/library/screenshot.spec.ts?

@hbenl
Copy link
Contributor Author

hbenl commented Aug 27, 2025

@hbenl, don't we also miss the firefox equivalent under tests/library/screenshot.spec.ts?

Those tests are skipped for firefox.

@whimboo
Copy link
Collaborator

whimboo commented Sep 3, 2025

For the failing tests there was an issue with the blob-report, which is unrelated to this change.

@yury-s, can we please get this PR reviewed and merged?

@yury-s yury-s merged commit 8972ec8 into microsoft:main Sep 5, 2025
24 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants