add spacy_stanza into stanza_nlp_engine as it is no longer maintained #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
presidio-analyzer/presidio_analyzer/nlp_engine/stanza_nlp_engine.py:136
- [nitpick] The function name 'tokenizer_factory' is ambiguous. It should be renamed to 'create_stanza_tokenizer' to better reflect its purpose.
def tokenizer_factory(
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SharonHart
previously approved these changes
Feb 5, 2025
SharonHart
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
spacy_stanza is a spacy wrapper for stanza. spacy-stanza only supports stanza versions below 1.7, and due to some changes in torch, stanza < 1.7 doesn't work (unless we downgrade torch).
This change adds the code from spacy_stanza into stanza_nlp_engine, as spacy_stanza is no longer maintained.
Tests were also added to the test_stanza_nlp_engine.py file to ensure that the code works as expected.