Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize complexity of filter out unwanted recognizers from O(n*m ) to O(n) #1523

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

rgupta2508
Copy link

@rgupta2508 rgupta2508 commented Feb 5, 2025

Reopen this PR #1508
Creating map of supported entity and recognizers and filtering out based on entity name using kay .

Code refactor.

Improve complexity of filter out unwanted recognizers from O(n*m )to O(n)

In current code for loop is running inside for loop that makes complexity to O(n*m). after this change there is only one loop by using one extra variable.
where
m = total number of all_possible_recognizers
n= total supported entities which we want to include .

Change Description

Describe your changes

Issue reference

This PR fixes issue #XX

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@rgupta2508
Copy link
Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant