Skip to content

save current tile map before loop in case tile map changed in overlap handlers #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
felixtsu wants to merge 6 commits into
base: master
Choose a base branch
from
Open

save current tile map before loop in case tile map changed in overlap handlers #1353

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bb34faa
speed -> rate
felixtsu Aug 28, 2020
dfe9455
Merge branch 'microsoft:master' into master
felixtsu Jul 28, 2021
07bedca
Chinese character support
felixtsu Jul 28, 2021
3617026
Merge branch 'microsoft:master' into master
felixtsu Jun 19, 2022
0cb099a
fix https://github.com/microsoft/pxt-arcade/issues/4819
felixtsu Jun 19, 2022
549d91b
fix https://github.com/microsoft/pxt-arcade/issues/4819
felixtsu Jun 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion libs/game/physics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,6 +596,8 @@ class ArcadePhysicsEngine extends PhysicsEngine {
protected tilemapOverlaps(sprite: Sprite, overlappedTiles: tiles.Location[]) {
const alreadyHandled: tiles.Location[] = [];

let currentTileMap = game.currentScene().tileMap

for (const tile of overlappedTiles) {
if (alreadyHandled.some(l => l.column === tile.column && l.row === tile.row)) {
continue;
Expand All @@ -605,12 +607,13 @@ class ArcadePhysicsEngine extends PhysicsEngine {
const tileOverlapHandlers = game.currentScene().tileOverlapHandlers;
if (tileOverlapHandlers) {
tileOverlapHandlers
.filter(h => h.spriteKind == sprite.kind() && h.tileKind.equals(tiles.getTileImage(tile)))
.filter(h => h.spriteKind == sprite.kind() && h.tileKind.equals(currentTileMap.getTileImage(tile.tileSet)))
.forEach(h => h.handler(sprite, tile));
}
}
}


/**
* Returns sprites that overlap with the given sprite. If type is non-zero, also filter by type.
* @param sprite
Expand Down