Modal : Added Titlebar , title , X handling , resizable and movable for windows #14636
+413
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Titlebar , title , X handling , resizable and movable for windows
Type of Change
Why
What is the motivation for this change? Add a few sentences describing the context and overall goals of the pull request's commits.
Resolves [Add Relevant Issue Here]
#14067
What
Added JS side hadndling for windows only prop Title .
Passed the prop from js side to native side and handled the behaviour if title has been passed and not
handled closing modal using X
modal is resizable
modal is movable
the title can be updated dynamically.
Screenshots
modal_new.mp4
modal_moves.mp4
Testing
tested in playground
Changelog
yes
Add a brief summary of the change to use in the release notes for the next release.
Added support for a title prop on Windows Modals, allowing a title bar to be displayed.
The modal window can now be closed using the 'X' button, triggering the onRequestClose event.
Modals with a title bar are now resizable, and the title can be updated dynamically.
Microsoft Reviewers: Open in CodeFlow