-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Update sort step method for assistant invoke. #10191
Open
moonbox3
wants to merge
6
commits into
microsoft:main
Choose a base branch
from
moonbox3:assistant-msg-ordering
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,159
−1,091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
Pull requests for the Python Semantic Kernel
label
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add some unit tests for this mechanism?
We have unit tests covering - but I will add some to check the order of messages. |
TaoChenOSU
approved these changes
Jan 16, 2025
python/semantic_kernel/agents/open_ai/open_ai_assistant_base.py
Outdated
Show resolved
Hide resolved
eavanvalkenburg
approved these changes
Jan 17, 2025
python/semantic_kernel/agents/open_ai/open_ai_assistant_base.py
Outdated
Show resolved
Hide resolved
TaoChenOSU
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
At times, when the (Azure) OpenAI Assistant Agent makes a tool call, that tool call's creation timestamp is coming after the message creation timestamp (the message creation being the text that the assistant responds with). Currently in our code, if we have a tool call (
FunctionCallContent
), we first yield that, and then we make a call to get completed steps, to then yield more content likeFunctionResultContent
andTextContent
. There will be two steps (or more, depending upon the number of tool calls).Right now we sort the completed steps in this way:
When there are no failures, it's because the tool call was created before the final message content (as has been since this assistant was first coded). However, it appears that processing on the server-side can cause fluctuations in when the steps are created/processed. When we have a failure, we now have the message_creation (
TextContent
) yielded before theFunctionResultContent
, which if sent to an (Azure) OpenAI Chat Completion endpoint will break with a 400 because of the gap in the ordering between theFunctionCallContent
and theFunctionResultContent
:The 400 error isn't 100% repeatable because of server-side processing, so we will get the correct ordering:
This PR updates the ordering of how we sort of the completed steps -- if we have a step_type == "tool_calls" and "message_creation", we sort to allow for "tool_calls" to come first, and any ties are broken by the step.completed_at timestamp. With this update, we no longer receive 400s because the ordering of the content types is correct when sending to an OpenAI model.
Description
This PR:
info
level.Contribution Checklist