Updated pane context menu by dm17ryk · Pull Request #18126 · microsoft/terminal

dm17ryk · 2024-10-30T12:20:45Z

Motivation

The motivation is that Windows users are more accustomed to working with GUI Menus using a mouse, unlike Linux users.

Summary of the Pull Request

added split pane with profile or duplicate up/down/left/right context menus as submenu
added swap panes up/down/left/right context menus as submenu
added toggle pane zoom context menu
added close other panes context menu

References :

Relevant Issues : (Enhance pane context menu #18137)

Type of change :

New feature

… swap panes context menu

…ntext menu

dm17ryk · 2024-10-30T12:22:40Z

@microsoft-github-policy-service agree

remove added values that fail ckecks

zadjii-msft

quick feedback before I review the rest of this

src/cascadia/TerminalApp/Resources/de-DE/Resources.resw

src/cascadia/TerminalApp/TerminalPage.cpp

…changes to all the Resources.resw files that aren't in the en-us dir

dm17ryk · 2024-11-01T08:28:19Z

quick feedback before I review the rest of this

Hi @zadjii-msft, All requested changes are addressed and fixed.

htcfreek · 2024-11-01T23:19:00Z

It feels odd that the split pane entries exists twice on the second level. Can you add a "same profile"/"duplicate" entry at the first position of the third level instead?

…cate pane' entry at the first position of the third level

dm17ryk · 2024-11-02T08:39:52Z

It feels odd that the split pane entries exists twice on the second level. Can you add a "same profile"/"duplicate" entry at the first position of the third level instead?

You're right, it looks better.
Done.

htcfreek · 2024-11-07T10:55:07Z

@dmitrykok
Maybe it is better visible with a separation line between the "duplicate" entry and the other ones. I think that would promote the duplicate entry more. What do you think?

…the other ones, changed from 'Duplicate pane' to 'Duplicate <profile_name>'

dm17ryk · 2024-12-11T18:17:45Z

@zadjii-msft don't see what changes are requested, and how to get there

Co-authored-by: Mike Griese <migrie@microsoft.com>

zadjii-msft · 2024-12-11T18:34:32Z

Yea I marked "needs feedback" because you said "All requested changes done" but forgot to push the commit 😉

…ache the value of profile.Name() and profile.Icon(), control always show Find by itself

…ue from the profile

dm17ryk · 2024-12-11T21:42:32Z

Hi @zadjii-msft, all nits fixed 😉.

dm17ryk · 2024-12-25T16:08:36Z

@lhecker

We've discussed the UX of the PR today, as seen in your PR description. We felt like we should not have the directions submenu and instead go directly to the profile list. Like this basically:

The split mode in this case would be "automatic". This is something we can do before merging the PR or after, but it's something we'd like to do before shipping this PR.

I think partly the purpose was, to split wanted direction and not automatic direction. Because many times auto decision is wrong.
Maybe I can add "Split pane auto" that will go directly to profile list.
But if I want something like this and not "random" panes placement, it will be not possible:

…u with all profiles, normal/left click with open profile with auto split and right click will open context menu wuth solit directions - right/down/up/left

dm17ryk · 2025-01-26T13:20:33Z

Hi, @lhecker , looks like I did find acceptable solution:

Pane split with profiles reworked, pane split context menu has one submenu with all profiles, normal/left click with open profile with auto split and right click will open context menu with split directions - right/down/up/left:

carlos-zamora

Just the one comment. Looks and feels great! Thanks for doing this :)

I'll circle back and approve it once Find gets added back in

src/cascadia/TerminalControl/TermControl.xaml

carlos-zamora

Oh wow. Sorry I didn't get to this sooner! I disappeared on medical leave right after submitting the review.

Thanks for being patient with us and I'm excited to see this in the upcoming release! 😊

Looks like most of his concerns were nits and they've all been addressed.

carlos-zamora · 2025-05-12T23:22:57Z

Demo from PR Body

Split right to Ubuntu profile from main pane:

Split down duplicate:

Split down to CMD profile from Ubuntu pane:

Split right to Fedora profile from Ubuntu pane:

Result window, with swap menus, you also can see "toggle pane zoom" and "close other panes" menus:

carlos-zamora · 2025-05-12T23:23:05Z

/azp run

azure-pipelines · 2025-05-12T23:23:15Z

Azure Pipelines successfully started running 1 pipeline(s).

carlos-zamora · 2025-05-15T22:09:03Z

/azp run

azure-pipelines · 2025-05-15T22:09:13Z

Azure Pipelines successfully started running 1 pipeline(s).

dm17ryk added 8 commits October 29, 2024 14:42

added split up/down/left/right context menus

0ac796f

added build win x64 release script

d920a70

moved split up/down/left/right context menus as submenu

7e41e64

added to split with profile to up/down/left/right context menu, added…

58cbe3a

… swap panes context menu

fix startup directory for split with profile to up/down/left/right co…

6e2529b

…ntext menu

Merge branch 'microsoft:main' into main

c953b44

update win x64 release build script

ef25c63

added translations for available languages

f900ea5

This comment has been minimized.

Sign in to view

Update settings.json

a57aff8

remove added values that fail ckecks

This comment has been minimized.

Sign in to view

Update settings.json

ae838ec

This comment has been minimized.

Sign in to view

removed newly added file

ab01742

zadjii-msft previously requested changes Oct 30, 2024

View reviewed changes

src/cascadia/TerminalApp/Resources/de-DE/Resources.resw Show resolved Hide resolved

src/cascadia/TerminalApp/TerminalPage.cpp Show resolved Hide resolved

microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Oct 30, 2024

put back comments removed by mistake in TerminalPage.cpp, revert the …

4ab861c

…changes to all the Resources.resw files that aren't in the en-us dir

microsoft-github-policy-service bot removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Oct 30, 2024

dm17ryk requested a review from zadjii-msft October 30, 2024 14:29

dm17ryk added 2 commits October 30, 2024 16:43

revert .vscode/settings.json

409783a

fixed Resources.resw SwapPaneText resource

e21c0b7

Update TerminalPage.cpp

12aad74

dm17ryk mentioned this pull request Nov 1, 2024

Enhance pane context menu #18137

Closed

the split pane entries exists twice on the second level, add a 'dupli…

f682222

…cate pane' entry at the first position of the third level

add visible with a separation line between the 'duplicate' entry and …

3bcaa51

…the other ones, changed from 'Duplicate pane' to 'Duplicate <profile_name>'

zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Dec 11, 2024

zadjii-msft assigned dm17ryk Dec 11, 2024

dm17ryk requested a review from zadjii-msft December 11, 2024 18:15

microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Dec 11, 2024

Update src/cascadia/TerminalApp/Resources/en-US/Resources.resw

54c9c60

Co-authored-by: Mike Griese <migrie@microsoft.com>

dm17ryk added 2 commits December 11, 2024 22:01

cache the value of focusedProfile.Name() and focusedProfile.Icon(), c…

9a936f4

…ache the value of profile.Name() and profile.Icon(), control always show Find by itself

No need to manually override the value from the profile, with the val…

8cf4ad6

…ue from the profile

pane split with profiles reworked, pane split context menu has submen…

ea1dc48

…u with all profiles, normal/left click with open profile with auto split and right click will open context menu wuth solit directions - right/down/up/left

carlos-zamora unassigned dm17ryk Mar 4, 2025

carlos-zamora reviewed Mar 4, 2025

View reviewed changes

src/cascadia/TerminalControl/TermControl.xaml Show resolved Hide resolved

Fix Find menu with selection

0d9f9b1

dm17ryk requested a review from carlos-zamora March 11, 2025 13:22

carlos-zamora approved these changes May 12, 2025

View reviewed changes

carlos-zamora enabled auto-merge (squash) May 12, 2025 23:23

run code formatter

bd99d02

carlos-zamora approved these changes May 15, 2025

View reviewed changes

PankajBhojwani approved these changes May 15, 2025

View reviewed changes

carlos-zamora merged commit a093ca3 into microsoft:main May 15, 2025
14 checks passed

Conversation

dm17ryk commented Oct 30, 2024 • edited by carlos-zamora Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Summary of the Pull Request

References :

Type of change :

Uh oh!

dm17ryk commented Oct 30, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

zadjii-msft left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dm17ryk commented Nov 1, 2024

Uh oh!

htcfreek commented Nov 1, 2024

Uh oh!

dm17ryk commented Nov 2, 2024

Uh oh!

htcfreek commented Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dm17ryk commented Dec 11, 2024

Uh oh!

zadjii-msft commented Dec 11, 2024

Uh oh!

dm17ryk commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dm17ryk commented Dec 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dm17ryk commented Jan 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

carlos-zamora left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

carlos-zamora left a comment

Choose a reason for hiding this comment

Uh oh!

carlos-zamora commented May 12, 2025

Demo from PR Body

Split right to Ubuntu profile from main pane:

Split down duplicate:

Split down to CMD profile from Ubuntu pane:

Split right to Fedora profile from Ubuntu pane:

Result window, with swap menus, you also can see "toggle pane zoom" and "close other panes" menus:

Uh oh!

carlos-zamora commented May 12, 2025

Uh oh!

azure-pipelines bot commented May 12, 2025

Uh oh!

carlos-zamora commented May 15, 2025

Uh oh!

azure-pipelines bot commented May 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dm17ryk commented Oct 30, 2024 •

edited by carlos-zamora

Loading

htcfreek commented Nov 7, 2024 •

edited

Loading

dm17ryk commented Dec 11, 2024 •

edited

Loading

dm17ryk commented Dec 25, 2024 •

edited

Loading

dm17ryk commented Jan 26, 2025 •

edited

Loading