Fix Assert.That to not evaluate expression twice #6699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Oct 8, 2025
Evangelink
commented
Oct 8, 2025
…soft/testfx into dev/amauryleve/assert-that
nohwnd
reviewed
Oct 8, 2025
test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.That.cs
Outdated
Show resolved
Hide resolved
# Conflicts: # src/TestFramework/TestFramework/Resources/FrameworkMessages.resx # test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.That.cs
Member
|
disabled automerge, I want to do some more testing, but now don't have any inspiration. So plese wait for me a day or 2. |
Member
|
When the method returns objects they will get merged in the cache, and only 1 instance is returned. Making it impossible to see what was returned. It probably needs to serialize the objects for the assertion as it goes, adding overhead for passing assertions, but also snapshotting the values better. Also this would avoid issues with the object overriding equals / gethash, when we grab it from the cache? 
The linked code returns 2 instances that have different data when they are evaluated, but I cannot see that from the output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6690