Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, thanks for the nice project.
This small PR adds support for Node's AbortController, which is the currently recommended way to abort requests in flight. I couldn't see any way to achieve this in the current version, and as the change is relatively minor I've put this PR quickly together to demonstrate what I mean. AbortControllers are already supported by the underlying
http.request()
andhttps.request()
methods; this PR simply passes an optional AbortSignal object through the various function calls to the underlying request.Usage:
Abort controllers are (sadly) single use only so specifying at the constructor/object level doesn't really make sense, hence the addition to the method call directly. Some of the method signatures are now getting a bit messy however, it might be more desirable to add
signal
to theIRequestOptions
or similar instead...Apologies if this functionality is unwanted/covered elsewhere.