Write list of unparsed fourslash tests to file #1447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the fourslash test conversion script to track progress by writing a list of unparsed tests to a file. This allows developers to monitor which tests still need to be parsed and converted.
- Adds functionality to write unparsed test names to a file for progress tracking
- Sorts the unparsed files list before writing to ensure consistent output
- Replaces console logging with file output for better persistence
gabritto
reviewed
Jul 24, 2025
.github/workflows/ci.yml
Outdated
| run: npm run updatefailing | ||
| run: | | ||
| npm run convertfourslash | ||
| npm run updatefailing |
There was a problem hiding this comment.
npm run updatefailing will run convertFourslash (twice), so, not sure why we'd need to add it here.
There was a problem hiding this comment.
Yeah I was just trying to figure out why the test is failing even though I already committed the file...
There was a problem hiding this comment.
I see. Yeah, I don't get why it's failing. 🙁
This reverts commit a827871.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way we know our progress.