Fix package id string to contain sub module #1592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the package ID string format to include the resolved submodule path instead of just the package name. The change ensures that package IDs contain the full path to the resolved module, making them more specific and unique.
- Updates the
PackageId.String()method to usePackageName()instead of the rawNamefield - Updates test baseline files to reflect the new package ID format that includes submodule paths
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/module/types.go | Changed PackageId.String() to use PackageName() method instead of raw Name field |
| testdata/baselines/reference/... | Updated 24 test baseline files to reflect new package ID format with submodule paths |
jakebailey
approved these changes
Aug 15, 2025
jakebailey
approved these changes
Aug 15, 2025
andrewbranch
pushed a commit
to andrewbranch/typescript-go
that referenced
this pull request
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while porting tsc -b tests