Porting of tsc -b -w #1684

sheetalkamat · 2025-09-05T16:07:30Z

No description provided.

…es are same

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

internal/execute/build/parseCache.go

jakebailey · 2025-09-08T20:43:49Z

I'm testing it out locally and it's not working. I started on tsgo -b src -w in the main TS repo, and then got an error that the diagnostics were not compiling. My mistake, I just pulled main and forgot to regenerate them.

But, I regenerated them and then tsgo did not continue building. I restarted it and now it's just hanging not doing anything. I'm not sure if the modtimes are just not right becuase it's not doing anything.

I put an error into binder.ts and the error did show up, but removing it did not print the message that says it's successfully compiled.

I deleted built and tried again, and it also didn't print anything.

So it feels like the good path isn't quite working?

sheetalkamat · 2025-09-08T22:07:09Z

I'm testing it out locally and it's not working. I started on tsgo -b src -w in the main TS repo, and then got an error that the diagnostics were not compiling. My mistake, I just pulled main and forgot to regenerate them.

But, I regenerated them and then tsgo did not continue building. I restarted it and now it's just hanging not doing anything. I'm not sure if the modtimes are just not right becuase it's not doing anything.

I put an error into binder.ts and the error did show up, but removing it did not print the message that says it's successfully compiled.

I deleted built and tried again, and it also didn't print anything.

So it feels like the good path isn't quite working?

Can you post log from --v
Here is what i see:

c:\TypeScript>c:\typescript-go\built\local\tsgo -b -v -w --diagnostics src
[03:04:35 PM] Projects in this build:
    * src/compiler/tsconfig.json
    * src/deprecatedCompat/tsconfig.json
    * src/jsTyping/tsconfig.json
    * src/services/tsconfig.json
    * src/typingsInstallerCore/tsconfig.json
    * src/server/tsconfig.json
    * src/harness/tsconfig.json
    * src/testRunner/tsconfig.json
    * src/tsc/tsconfig.json
    * src/typescript/tsconfig.json
    * src/tsserver/tsconfig.json
    * src/typingsInstaller/tsconfig.json
    * src/watchGuard/tsconfig.json
    * src/tsconfig.json

[03:04:35 PM] Project 'src/compiler/tsconfig.json' is out of date because output for it was generated with version '5.9.2' that differs with current version '7.0.0-dev'

[03:04:35 PM] Building project 'src/compiler/tsconfig.json'...

Files:                    225
Lines:                 259903
Identifiers:           434477
Symbols:               341060
Types:                 198483
Instantiations:        264243
Memory used:          338403K
Memory allocs:        3694795
Config time:           0.009s
Parse time:            0.176s
Check time:            1.163s
Emit time:             0.107s
Changes compute time:  0.025s
Total time:            1.490s
[03:04:37 PM] Project 'src/deprecatedCompat/tsconfig.json' is out of date because output for it was generated with version '5.9.2' that differs with current version '7.0.0-dev'

[03:04:37 PM] Building project 'src/deprecatedCompat/tsconfig.json'...

Files:                    126
Lines:                  30120
Identifiers:            48796
Symbols:                31240
Types:                    909
Instantiations:           739
Memory used:          363789K
Memory allocs:        3943827
Config time:           0.006s
Parse time:            0.014s
Check time:            0.008s
Emit time:             0.004s
Changes compute time:  0.007s
Total time:            1.635s
[03:04:37 PM] Project 'src/jsTyping/tsconfig.json' is out of date because output for it was generated with version '5.9.2' that differs with current version '7.0.0-dev'

[03:04:37 PM] Building project 'src/jsTyping/tsconfig.json'...

Files:                    229
Lines:                  86188
Identifiers:            89819
Symbols:                62383
Types:                   1610
Instantiations:           824
Memory used:          363789K
Memory allocs:        3943827
Config time:           0.007s
Parse time:            0.012s
Check time:            0.016s
Emit time:             0.025s
Changes compute time:  0.007s
Total time:            1.664s
[03:04:37 PM] Project 'src/services/tsconfig.json' is out of date because output for it was generated with version '5.9.2' that differs with current version '7.0.0-dev'

[03:04:37 PM] Building project 'src/services/tsconfig.json'...

Files:                    297
Lines:                  95706
Identifiers:           179453
Symbols:               189174
Types:                  85732
Instantiations:        124900
Memory used:          509606K
Memory allocs:        5555239
Config time:           0.010s
Parse time:            0.048s
Check time:            0.501s
Emit time:             0.047s
Changes compute time:  0.017s
Total time:            2.498s
[03:04:37 PM] Project 'src/typingsInstallerCore/tsconfig.json' is out of date because output for it was generated with version '5.9.2' that differs with current version '7.0.0-dev'

[03:04:37 PM] Building project 'src/typingsInstallerCore/tsconfig.json'...

Files:                    233
Lines:                  86342
Identifiers:            90184
Symbols:                62687
Types:                   1366
Instantiations:          1014
Memory used:          474067K
Memory allocs:        4712210
Config time:           0.006s
Parse time:            0.009s
Check time:            0.025s
Emit time:             0.008s
Changes compute time:  0.010s
Total time:            1.937s
[03:04:38 PM] Project 'src/server/tsconfig.json' is out of date because output for it was generated with version '5.9.2' that differs with current version '7.0.0-dev'

[03:04:38 PM] Building project 'src/server/tsconfig.json'...

Files:                    418
Lines:                 109266
Identifiers:           126472
Symbols:               105882
Types:                  23164
Instantiations:         23719
Memory used:          551660K
Memory allocs:        6086422
Config time:           0.008s
Parse time:            0.017s
Check time:            0.089s
Emit time:             0.026s
Changes compute time:  0.003s
Total time:            2.815s
[03:04:38 PM] Project 'src/harness/tsconfig.json' is out of date because output for it was generated with version '5.9.2' that differs with current version '7.0.0-dev'

[03:04:38 PM] Building project 'src/harness/tsconfig.json'...

Files:                    476
Lines:                 119242
Identifiers:           145026
Symbols:               119988
Types:                  28249
Instantiations:         21411
Memory used:          618576K
Memory allocs:        7200655
Config time:           0.008s
Parse time:            0.025s
Check time:            0.292s
Emit time:             0.029s
Changes compute time:  0.010s
Total time:            3.384s
[03:04:39 PM] Project 'src/testRunner/tsconfig.json' is out of date because output for it was generated with version '5.9.2' that differs with current version '7.0.0-dev'

[03:04:39 PM] Building project 'src/testRunner/tsconfig.json'...

Files:                    756
Lines:                 185727
Identifiers:           222635
Symbols:               235666
Types:                  86747
Instantiations:         43217
Memory used:          752166K
Memory allocs:        8589245
Config time:           0.012s
Parse time:            0.088s
Check time:            0.226s
Emit time:             0.112s
Changes compute time:  0.046s
Total time:            4.240s
[03:04:37 PM] Project 'src/tsc/tsconfig.json' is out of date because output for it was generated with version '5.7.3' that differs with current version '7.0.0-dev'

[03:04:37 PM] Building project 'src/tsc/tsconfig.json'...

Files:                    125
Lines:                  29917
Identifiers:            48425
Symbols:                30601
Types:                    402
Instantiations:             2
Memory used:          363694K
Memory allocs:        3943604
Config time:           0.007s
Parse time:            0.014s
Check time:            0.006s
Emit time:             0.002s
Changes compute time:  0.007s
Total time:            1.631s
[03:04:38 PM] Project 'src/typescript/tsconfig.json' is out of date because output for it was generated with version '5.9.2' that differs with current version '7.0.0-dev'

[03:04:38 PM] Building project 'src/typescript/tsconfig.json'...

Files:                    321
Lines:                  40083
Identifiers:            61990
Symbols:                40720
Types:                    360
Instantiations:             0
Memory used:          606062K
Memory allocs:        6653342
Config time:           0.008s
Parse time:            0.017s
Check time:            0.011s
Emit time:             0.005s
Changes compute time:  0.005s
Total time:            3.065s
[03:04:39 PM] Project 'src/tsserver/tsconfig.json' is out of date because output for it was generated with version '5.7.3' that differs with current version '7.0.0-dev'

[03:04:39 PM] Building project 'src/tsserver/tsconfig.json'...

Files:                    424
Lines:                  96537
Identifiers:           104062
Symbols:                77177
Types:                   4039
Instantiations:          2979
Memory used:          720241K
Memory allocs:        7558947
Config time:           0.007s
Parse time:            0.015s
Check time:            0.057s
Emit time:             0.033s
Changes compute time:  0.004s
Total time:            3.467s
[03:04:39 PM] Project 'src/typingsInstaller/tsconfig.json' is out of date because output for it was generated with version '5.7.3' that differs with current version '7.0.0-dev'

[03:04:39 PM] Building project 'src/typingsInstaller/tsconfig.json'...

Files:                    422
Lines:                  95939
Identifiers:           103000
Symbols:                72170
Types:                   1095
Instantiations:           525
Memory used:          720241K
Memory allocs:        7558947
Config time:           0.006s
Parse time:            0.015s
Check time:            0.055s
Emit time:             0.035s
Changes compute time:  0.004s
Total time:            3.467s
[03:04:35 PM] Project 'src/watchGuard/tsconfig.json' is out of date because output for it was generated with version '5.7.3' that differs with current version '7.0.0-dev'

[03:04:35 PM] Building project 'src/watchGuard/tsconfig.json'...

Files:                    146
Lines:                  65568
Identifiers:            48829
Symbols:                36665
Types:                    549
Instantiations:            14
Memory used:          130683K
Memory allocs:         281194
Config time:           0.008s
Parse time:            0.122s
Check time:            0.001s
Emit time:             0.005s
Changes compute time:  0.009s
Total time:            0.157s
Projects in scope:                    14
Projects built:                       13
Timestamps only updates:               0
Aggregate Files:                    4198
Aggregate Lines:                 1300538
Aggregate Identifiers:           1703168
Aggregate Symbols:               1405413
Aggregate Types:                  432705
Aggregate Instantiations:         483587
Aggregate Memory used:          6512982K
Aggregate Memory allocs:        69722254
Aggregate Config time:            0.104s
Aggregate Parse time:             0.572s
Aggregate Check time:             2.450s
Aggregate Emit time:              0.438s
Aggregate Changes compute time:   0.153s
Aggregate Total time:             4.503s
[03:05:10 PM] Projects in this build:
    * src/compiler/tsconfig.json
    * src/deprecatedCompat/tsconfig.json
    * src/jsTyping/tsconfig.json
    * src/services/tsconfig.json
    * src/typingsInstallerCore/tsconfig.json
    * src/server/tsconfig.json
    * src/harness/tsconfig.json
    * src/testRunner/tsconfig.json
    * src/tsc/tsconfig.json
    * src/typescript/tsconfig.json
    * src/tsserver/tsconfig.json
    * src/typingsInstaller/tsconfig.json
    * src/watchGuard/tsconfig.json
    * src/tsconfig.json

[03:05:10 PM] Project 'src/compiler/tsconfig.json' is out of date because output 'built/local/compiler/tsconfig.tsbuildinfo' is older than input 'src/compiler/binder.ts'

[03:05:10 PM] Building project 'src/compiler/tsconfig.json'...

src/compiler/binder.ts:414:53 - error TS2551: Property 'Instantiateddd' does not exist on type 'typeof ModuleInstanceState'. Did you mean 'Instantiated'?

414                         state = ModuleInstanceState.Instantiateddd;
                                                        ~~~~~~~~~~~~~~

  src/compiler/binder.ts:329:5 - 'Instantiated' is declared here.
    329     Instantiated = 1,
            ~~~~~~~~~~~~

Files:                    225
Lines:                 259903
Identifiers:           434477
Symbols:               133068
Types:                  19466
Instantiations:         13712
Memory used:          617432K
Memory allocs:        9649660
Parse time:            0.124s
Check time:            0.098s
Emit time:             0.006s
Changes compute time:  0.045s
Total time:           34.869s
[03:05:11 PM] Project 'src/deprecatedCompat/tsconfig.json' is up to date with .d.ts files from its dependencies

[03:05:11 PM] Updating output timestamps of project 'src/deprecatedCompat/tsconfig.json'...

[03:05:11 PM] Project 'src/jsTyping/tsconfig.json' is up to date with .d.ts files from its dependencies

[03:05:11 PM] Updating output timestamps of project 'src/jsTyping/tsconfig.json'...

[03:05:11 PM] Project 'src/services/tsconfig.json' is up to date with .d.ts files from its dependencies

[03:05:11 PM] Updating output timestamps of project 'src/services/tsconfig.json'...

[03:05:11 PM] Project 'src/typingsInstallerCore/tsconfig.json' is up to date with .d.ts files from its dependencies

[03:05:11 PM] Updating output timestamps of project 'src/typingsInstallerCore/tsconfig.json'...

[03:05:11 PM] Project 'src/server/tsconfig.json' is up to date with .d.ts files from its dependencies

[03:05:11 PM] Updating output timestamps of project 'src/server/tsconfig.json'...

[03:05:11 PM] Project 'src/harness/tsconfig.json' is up to date with .d.ts files from its dependencies

[03:05:11 PM] Updating output timestamps of project 'src/harness/tsconfig.json'...

[03:05:11 PM] Project 'src/testRunner/tsconfig.json' is up to date with .d.ts files from its dependencies

[03:05:11 PM] Updating output timestamps of project 'src/testRunner/tsconfig.json'...

[03:05:11 PM] Project 'src/tsc/tsconfig.json' is up to date with .d.ts files from its dependencies

[03:05:11 PM] Updating output timestamps of project 'src/tsc/tsconfig.json'...

[03:05:11 PM] Project 'src/typescript/tsconfig.json' is up to date with .d.ts files from its dependencies

[03:05:11 PM] Updating output timestamps of project 'src/typescript/tsconfig.json'...


Found 1 error in src/compiler/binder.ts:414

Projects in scope:                   14
Projects built:                       1
Timestamps only updates:              9
Aggregate Files:                    225
Aggregate Lines:                 259903
Aggregate Identifiers:           434477
Aggregate Symbols:               133068
Aggregate Types:                  19466
Aggregate Instantiations:         13712
Aggregate Memory used:          617432K
Aggregate Memory allocs:        9649660
Aggregate Parse time:            0.124s
Aggregate Check time:            0.098s
Aggregate Emit time:             0.006s
Aggregate Changes compute time:  0.045s
Aggregate Total time:           35.223s
[03:05:18 PM] Projects in this build:
    * src/compiler/tsconfig.json
    * src/deprecatedCompat/tsconfig.json
    * src/jsTyping/tsconfig.json
    * src/services/tsconfig.json
    * src/typingsInstallerCore/tsconfig.json
    * src/server/tsconfig.json
    * src/harness/tsconfig.json
    * src/testRunner/tsconfig.json
    * src/tsc/tsconfig.json
    * src/typescript/tsconfig.json
    * src/tsserver/tsconfig.json
    * src/typingsInstaller/tsconfig.json
    * src/watchGuard/tsconfig.json
    * src/tsconfig.json

[03:05:18 PM] Project 'src/compiler/tsconfig.json' is out of date because buildinfo file 'built/local/compiler/tsconfig.tsbuildinfo' indicates that program needs to report errors.

[03:05:18 PM] Building project 'src/compiler/tsconfig.json'...

Files:                     225
Lines:                  259903
Identifiers:            434477
Symbols:                133068
Types:                   19465
Instantiations:          13712
Memory used:           617359K
Memory allocs:        10228607
Parse time:             0.119s
Check time:             0.108s
Emit time:              0.007s
Changes compute time:   0.032s
Total time:            42.666s
[03:05:18 PM] Project 'src/deprecatedCompat/tsconfig.json' is up to date with .d.ts files from its dependencies

[03:05:18 PM] Updating output timestamps of project 'src/deprecatedCompat/tsconfig.json'...

[03:05:18 PM] Project 'src/jsTyping/tsconfig.json' is up to date with .d.ts files from its dependencies

[03:05:18 PM] Updating output timestamps of project 'src/jsTyping/tsconfig.json'...

[03:05:18 PM] Project 'src/services/tsconfig.json' is up to date with .d.ts files from its dependencies

[03:05:18 PM] Updating output timestamps of project 'src/services/tsconfig.json'...

[03:05:18 PM] Project 'src/typingsInstallerCore/tsconfig.json' is up to date with .d.ts files from its dependencies

[03:05:18 PM] Updating output timestamps of project 'src/typingsInstallerCore/tsconfig.json'...

[03:05:18 PM] Project 'src/server/tsconfig.json' is up to date with .d.ts files from its dependencies

[03:05:18 PM] Updating output timestamps of project 'src/server/tsconfig.json'...

[03:05:18 PM] Project 'src/harness/tsconfig.json' is up to date with .d.ts files from its dependencies

[03:05:18 PM] Updating output timestamps of project 'src/harness/tsconfig.json'...

[03:05:18 PM] Project 'src/testRunner/tsconfig.json' is up to date with .d.ts files from its dependencies

[03:05:18 PM] Updating output timestamps of project 'src/testRunner/tsconfig.json'...

[03:05:18 PM] Project 'src/tsc/tsconfig.json' is up to date with .d.ts files from its dependencies

[03:05:18 PM] Updating output timestamps of project 'src/tsc/tsconfig.json'...

[03:05:18 PM] Project 'src/typescript/tsconfig.json' is up to date with .d.ts files from its dependencies

[03:05:18 PM] Updating output timestamps of project 'src/typescript/tsconfig.json'...

Projects in scope:                    14
Projects built:                        1
Timestamps only updates:               9
Aggregate Files:                     225
Aggregate Lines:                  259903
Aggregate Identifiers:            434477
Aggregate Symbols:                133068
Aggregate Types:                   19465
Aggregate Instantiations:          13712
Aggregate Memory used:           617359K
Aggregate Memory allocs:        10228607
Aggregate Parse time:             0.119s
Aggregate Check time:             0.108s
Aggregate Emit time:              0.007s
Aggregate Changes compute time:   0.032s
Aggregate Total time:            43.133s

sheetalkamat · 2025-09-08T22:08:32Z

Also forgot that i had todo to print "watching for file changes" etc that i havent done. Will push that commit soon

jakebailey · 2025-09-08T22:28:59Z

I do see messages and progression under -v, so it's likely just missing the printout.

sheetalkamat · 2025-09-09T03:11:01Z

@jakebailey added messages about starting compilation

jakebailey

Does seem to work as expected now.

I can't say I like the testing callbacks/interface thing (which gets more and more hooks), rather than more isolated testing that just plain uses the CLI directly and observes the final result (or, unit tests for internal items), but I think it's probably okay for now.

sheetalkamat added 30 commits September 4, 2025 11:44

stub for watch

42590bc

basic test

8e54774

Update status

2ae229f

Reuse tasks and build order when we can

2278dfd

Cache buildInfo for life time

2d5feee

use writeFile callback to get updates about writing

e1a0d55

rename

182364b

Handle mtimes caching

19f5686

Handle updates to mTimes in test

6e15d4c

Fix the dts emit time stamp reversal found from test update

75ab83d

tsc -b -w root tests porting

45d6996

Fix issue with noChange retaining input times in cache

258a27f

reexport test

69fd252

Fix incorrect resets for errors

77cbab1

tsc -b -w program updates tests

38554fc

Fix strict value checking

51aafa3

Fix duplicate error reporting

e9c4a24

Dirty automatically adds to pending update

f466e1f

tsc -b -w noEmitOnError tests

e058f9c

Fix the timestamp update for buildInfo in nonIncremental mode

74e01c9

Fix unnecessary tsbuildinfo emits when getting cached dts diagnostics

2198655

tsc -b -w noEmit testcases

c812ed4

Fix incorrectly storing timestamps of file where input and output nam…

8ca329d

…es are same

tsc -b -w module resolution tests

3284900

Fix incorrect reporting of symlink delete

25032de

tsc -b -w libResolution tests

efb53b3

tsc -b -w extends test case

fafb8d5

config file errors porting

9a1b6ce

Fix race in source file caching

334b380

Fix race in creating build task

ea637ee

sheetalkamat marked this pull request as ready for review September 5, 2025 17:33

sheetalkamat requested review from Copilot, andrewbranch and jakebailey September 5, 2025 17:33

Copilot AI reviewed Sep 5, 2025

View reviewed changes

sheetalkamat mentioned this pull request Sep 5, 2025

Use package.json locations to determine uptodate ness #1686

Draft

jakebailey reviewed Sep 8, 2025

View reviewed changes

internal/execute/build/parseCache.go Show resolved Hide resolved

Merge branch 'main' into watchMode

983a1c8

Add starting and waiting for changes status

b4d1165

jakebailey approved these changes Sep 9, 2025

View reviewed changes

sheetalkamat added this pull request to the merge queue Sep 9, 2025

Merged via the queue into main with commit d7887e0 Sep 9, 2025
22 checks passed

sheetalkamat deleted the watchMode branch September 9, 2025 18:24

ghiscoding mentioned this pull request Sep 9, 2025

TODO: Implement project references #529

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Porting of tsc -b -w #1684

Porting of tsc -b -w #1684

sheetalkamat commented Sep 5, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

jakebailey commented Sep 8, 2025

Uh oh!

sheetalkamat commented Sep 8, 2025

Uh oh!

sheetalkamat commented Sep 8, 2025

Uh oh!

jakebailey commented Sep 8, 2025 •

edited

Loading

Uh oh!

sheetalkamat commented Sep 9, 2025

Uh oh!

jakebailey left a comment

Uh oh!

Uh oh!

Uh oh!

Porting of tsc -b -w #1684

Porting of tsc -b -w #1684

Conversation

sheetalkamat commented Sep 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jakebailey commented Sep 8, 2025

Uh oh!

sheetalkamat commented Sep 8, 2025

Uh oh!

sheetalkamat commented Sep 8, 2025

Uh oh!

jakebailey commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sheetalkamat commented Sep 9, 2025

Uh oh!

jakebailey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jakebailey commented Sep 8, 2025 •

edited

Loading