Skip to content

Prevent renaming keywords by validating in handleRename #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 6 commits into
base: main
Choose a base branch
from
+61 −4
Draft

Prevent renaming keywords by validating in handleRename #2231

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3856f25
Initial plan
Copilot Dec 4, 2025
d1f3da7
Implement prepareRename LSP handler
Copilot Dec 4, 2025
e3ff2e0
Update rename eligibility check and add tests
Copilot Dec 4, 2025
b7b67c4
Simplify rename validation without prepareRename
Copilot Dec 4, 2025
d8a16fb
Localize diagnostic message properly
Copilot Dec 4, 2025
3b02540
Fix format string bug in error creation
Copilot Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal/ls/findallreferences.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import (
"github.com/microsoft/typescript-go/internal/core"
"github.com/microsoft/typescript-go/internal/debug"
"github.com/microsoft/typescript-go/internal/diagnostics"
"github.com/microsoft/typescript-go/internal/locale"
"github.com/microsoft/typescript-go/internal/ls/lsconv"
"github.com/microsoft/typescript-go/internal/lsp/lsproto"
"github.com/microsoft/typescript-go/internal/scanner"
Expand Down Expand Up @@ -669,7 +670,7 @@ func (l *LanguageService) ProvideRenameFromSymbolAndEntries(ctx context.Context,
// Check if ProvideSymbolsAndEntries returned ok=false or no symbols found
// Return an error to inform the user that rename is not available
if symbolsAndEntries == nil || len(symbolsAndEntries) == 0 {
return lsproto.WorkspaceEditOrNull{}, fmt.Errorf("%s", diagnostics.You_cannot_rename_this_element)
return lsproto.WorkspaceEditOrNull{}, fmt.Errorf(diagnostics.You_cannot_rename_this_element.Localize(locale.FromContext(ctx)))
Copy link
Member

@jakebailey jakebailey Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot This is a bug; you are passing a message into the format string of a *f func

Copy link
Contributor Author

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 3b02540 - now using errors.New() instead of fmt.Errorf() to avoid treating the localized message as a format string.

}

program := l.GetProgram()
Expand Down