fix(3242): check class name collisions with Object#3248
Closed
a-tarasyuk wants to merge 1 commit intomicrosoft:mainfrom
Closed
fix(3242): check class name collisions with Object#3248a-tarasyuk wants to merge 1 commit intomicrosoft:mainfrom
a-tarasyuk wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Member
|
I think we actually need something that goes further, like #2087, since there are more checks like this. Though this particular filed issue is fun because it reveals that we were somehow only checking this in non-ESM files. |
Member
|
To be clear, that other PR could be overcomplicated, so I'm not saying to close this, rather that there's a wider range of missing code we seem to need. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3242