Skip to content

fix(3242): check class name collisions with Object#3248

Closed
a-tarasyuk wants to merge 1 commit intomicrosoft:mainfrom
a-tarasyuk:fix/3242
Closed

fix(3242): check class name collisions with Object#3248
a-tarasyuk wants to merge 1 commit intomicrosoft:mainfrom
a-tarasyuk:fix/3242

Conversation

@a-tarasyuk
Copy link
Copy Markdown
Contributor

Fixes #3242

@jakebailey
Copy link
Copy Markdown
Member

I think we actually need something that goes further, like #2087, since there are more checks like this. Though this particular filed issue is fun because it reveals that we were somehow only checking this in non-ESM files.

@jakebailey
Copy link
Copy Markdown
Member

To be clear, that other PR could be overcomplicated, so I'm not saying to close this, rather that there's a wider range of missing code we seem to need.

@a-tarasyuk a-tarasyuk closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No error for values named 'Object' (in CommonJS)

2 participants