Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Port emitter functions #600

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feature: Port emitter functions #600

wants to merge 4 commits into from
+92 −19

Conversation

KeoFoxy
Copy link
Contributor

@KeoFoxy KeoFoxy commented Mar 14, 2025 •
edited
Loading

Ported:

  • IsEmitBlocked
  • getSourceMapFilePath
  • getDeclarationEmitOutputFilePath
  • getDeclarationEmitOutputFilePathWorker
  • GetDeclarationEmitExtensionForPath

Added

  • SetEmitBlocked
  • BuildInfo struct for future usage

KeoFoxy
KeoFoxy commented Mar 15, 2025
View reviewed changes
internal/compiler/buildInfo.go
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I keep it for future use and scaling, or should I delete it?

@jakebailey
Copy link
Member

I'm not entirely convinced it's a good idea to port these functions now, when they aren't be used or tested, and may not actually be useful for future code.

@KeoFoxy
Copy link
Contributor Author

KeoFoxy commented Mar 15, 2025

They were marked as TODOs so I decided to port them. So should I keep only used ones? What about BuildInfo? Remove it as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KeoFoxy @jakebailey