LSP Notification Message Type #749
Open
+109
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyl10s
commented
Apr 4, 2025
dyl10s
commented
- Added lsp notification message type, as the todo comment stated the difference is if an ID is provided or not.
- A few of the messages that were being handled were notifications, so they are all now parsed/typed correctly.
Co-authored-by: Copilot <[email protected]>
jakebailey
reviewed
Apr 4, 2025
internal/lsp/lsproto/jsonrpc.go
Outdated
| var raw struct { | ||
| JSONRPC JSONRPCVersion `json:"jsonrpc"` | ||
| ID *ID `json:"id"` | ||
| ID *ID `json:"id,omitempty"` |
There was a problem hiding this comment.
Generally speaking, we should be using omitzero (new in Go 1.24) rather than omitempty.
There was a problem hiding this comment.
There are other of these, FWIW, I just commented on the one.
There was a problem hiding this comment.
I went ahead and normalized this file to always use omitzero!
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
internal/lsp/server.go:193
- [nitpick] For unknown request methods that include an ID, consider returning an error (such as using sendError) rather than solely logging the event, to notify clients of invalid requests.
s.Log("unknown method", req.Method)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.