Java codegen, use TCGC enum name for MPG

[XiaofeiCao]

• fix tsp, honor name for Enum in TypeSpec Azure/autorest.java#2940
• test generated with no diff

[azure-sdk]

No changes needing a change description found.

[azure-sdk]

You can try these changes here

🛝 Playground	🌐 Website	📚 Next docs

[haolingdong-msft]

is there any test to cover this?

[XiaofeiCao]

is there any test to cover this?

Yeah, I'm adding that. I'll skip Swagger fluent-test for now since currently we don't have that in microsoft/typespec.

[weidongxu-microsoft]

The repo is not yet up-to-date, so local test would do, at present.

[XiaofeiCao]

Result of using TCGC enum description.

[XiaofeiCao]

Result of using TCGC enum name:
https://github.com/Azure/typespec-azure/blob/c76a9c190ec5753627e56365dce8dd0ca53486f3/packages/typespec-azure-resource-manager/lib/common-types/managed-identity.tsp#L75

union ManagedServiceIdentityType {
  /** No managed identity. */
  None: "None",

  /** System assigned managed identity. */
  SystemAssigned: "SystemAssigned",

  /** User assigned managed identity. */
  UserAssigned: "UserAssigned",

  /** System and user assigned managed identity. */
  @renamedFrom(Versions.v3, "SystemAndUserAssigned")
  @removed(Versions.v4)
  SystemAndUserAssignedV3: "SystemAssigned,UserAssigned",

  /** System and user assigned managed identity. */
  @added(Versions.v4)
  @renamedFrom(Versions.v4, "SystemAndUserAssigned")
  @removed(Versions.v5)
  SystemAndUserAssignedV4: "SystemAssigned, UserAssigned",

  /** System and user assigned managed identity. */
  @added(Versions.v5)
  SystemAndUserAssigned: "SystemAssigned,UserAssigned",

  string,
}

[XiaofeiCao]

Not sure it's a good enum name...
@renamedFrom(Versions.v4, "SystemAndUserAssigned") should mean its should've been SystemAndUserAssigned, not sure if it's a TCGC bug.

[weidongxu-microsoft]

I can see the reason, but this is pretty unexpected.

On @renamedFrom(Versions.v3, "SystemAndUserAssigned"), did typespec actually wish name "SystemAndUserAssigned" be used (but projection seems not handling this?)?
E.g., how typespec-autorest handles this?

[XiaofeiCao]

It's referencing common types...

"identity": {
  "$ref": "../../../../common-types/v3/managedidentity.json#/definitions/ManagedServiceIdentity",
  "description": "Managed identity."
}

Even if emit-common-types-schema: for-visibility-changes, generated type will still reference that from common types:

"type": {
  "$ref": "../../../../common-types/v3/managedidentity.json#/definitions/ManagedServiceIdentityType",
}

In common types, it's defined as:

 "ManagedServiceIdentityType": {
  "description": "Type of managed service identity (where both SystemAssigned and UserAssigned types are allowed).",
  "enum": [
    "None",
    "SystemAssigned",
    "UserAssigned",
    "SystemAssigned,UserAssigned"
  ],
  "type": "string",
  "x-ms-enum": {
    "name": "ManagedServiceIdentityType",
    "modelAsString": true
  }
}

I guess this will differ with m4 generated name.

[XiaofeiCao]

Synced with Chenjie, the tsp definition seems not correct. I'll create an issue for TypeSpec team.

[XiaofeiCao]

If tsp:

union DogKind {
  string,

  @doc("Species golden")
  Golden: "golden_dog",

  @doc("Species golden")
  @added(Versions.v2023_11_01)
  @removed(Versions.v2023_12_01_preview)
  @renamedFrom(Versions.v2023_11_01, "Bull")
  Bull1: "bull_dog",

  @doc("Species golden")
  @added(Versions.v2023_12_01_preview)
  @renamedFrom(Versions.v2023_12_01_preview, "Bull")
  Bull2: "bull_dog",
}

When generating for Versions.v2023_12_01_preview, Swagger would be:

"DogKind": {
  "type": "string",
  "description": "extensible enum type for discriminator",
  "enum": [
    "golden_dog",
    "bull_dog"
  ],
  "x-ms-enum": {
    "name": "DogKind",
    "modelAsString": true,
    "values": [
      {
        "name": "Golden",
        "value": "golden_dog",
        "description": "Species golden"
      },
      {
        "name": "Bull2",
        "value": "bull_dog",
        "description": "Species golden"
      }
    ]
  }
}

Same issue.

[XiaofeiCao]

issue: Azure/typespec-azure#1465

[XiaofeiCao]

They've fixed it: https://github.com/Azure/typespec-azure/pull/1551/files

Now Swagger and TypeSpec matches each other.
Swagger: https://github.com/Azure/azure-rest-api-specs/blob/a3b67e1e3a9554951860b9f9d2e1723036a5e032/specification/common-types/resource-management/v5/managedidentity.json#L42

"ManagedServiceIdentityType": {
  "description": "Type of managed service identity (where both SystemAssigned and UserAssigned types are allowed).",
  "enum": [
    "None",
    "SystemAssigned",
    "UserAssigned",
    "SystemAssigned,UserAssigned"
  ],
  "type": "string",
  "x-ms-enum": {
    "name": "ManagedServiceIdentityType",
    "modelAsString": true
  }
}

Since no release this month uses identity(mongocluster, fabric, computeschedule), and ExpandableEnum relies on some of this PR's implementation, I'll merge this PR.