http-client-java, report TCGC diagnostics #4382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:java
|
No changes needing a change description found. |
weidongxu-microsoft
force-pushed
the
http-client-java_report-tcgc-diagnostic
branch
from
ef95eb0
to
b1ab16a
Compare
weidongxu-microsoft
changed the title
|
You can try these changes here
|
srnagar
approved these changes
Sep 10, 2024
This comment was marked as outdated.
This comment was marked as outdated.
tadelesh
approved these changes
Sep 18, 2024
weidongxu-microsoft
requested review from
haolingdong-msft and
XiaofeiCao
as code owners
XiaofeiCao
approved these changes
Oct 11, 2024
weidongxu-microsoft
deleted the
http-client-java_report-tcgc-diagnostic
branch
|
Currently reverted due to Azure/typespec-azure#1675 |
swatkatz
pushed a commit
to swatkatz/typespec
that referenced
this pull request
Nov 5, 2024
link Azure/typespec-azure#1487 tested with ``` Union U { null; }; ``` after this PR, we will see ``` C:/github/typespec/packages/http-client-java/generator/http-client-generator-test/main.tsp:15:7 - error @azure-tools/typespec-client-generator-core/union-null: Cannot have a union containing only null types. > 15 | union U { | ^ ``` and codegen fails (as this is an error).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link Azure/typespec-azure#1487
tested with
after this PR, we will see
and codegen fails (as this is an error).