Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Generator to support Parent parameters #4392

Merged
merged 82 commits into from
Oct 17, 2024

Conversation

nisha-bhatia
Copy link
Contributor

@nisha-bhatia nisha-bhatia commented Sep 10, 2024

Fixes: #3969

@nisha-bhatia nisha-bhatia self-assigned this Sep 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Sep 10, 2024
Copy link
Contributor

@jorgerangel-msft jorgerangel-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to avoid another review cycle. There are a few cleanup items left that should be addressed, but otherwise it looks good.

@nisha-bhatia nisha-bhatia added this pull request to the merge queue Oct 17, 2024
Merged via the queue into microsoft:main with commit a689659 Oct 17, 2024
21 checks passed
@nisha-bhatia nisha-bhatia deleted the nibhati-cadl branch October 17, 2024 22:15
swatkatz pushed a commit to swatkatz/typespec that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt http\client\structure\renamed-operation from cadl ranch
5 participants