Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enum in union example #4462

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Fix enum in union example #4462

merged 3 commits into from
Oct 4, 2024

Conversation

timotheeguerin
Copy link
Member

fix #4416

@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 17, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/compiler
Show changes

@typespec/compiler - fix ✏️

Fix examples with enums inside of unions

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@timotheeguerin timotheeguerin added this pull request to the merge queue Oct 4, 2024
Merged via the queue into microsoft:main with commit 7c425cd Oct 4, 2024
22 checks passed
@timotheeguerin timotheeguerin deleted the fix/enum-in-union-example branch October 4, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allenjzhang allenjzhang allenjzhang approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Empty example object was emitted when the model contains a enum type property
3 participants
@timotheeguerin @azure-sdk @allenjzhang