Implement tsp namespace for http-client-csharp #5443
Conversation
ArcturusZhang
force-pushed
the
implement-namespace
branch
from
fb24e3a to
4e7b1e3
Compare
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
API change check APIView has identified API level changes in this PR and created following API reviews. Microsoft.Generator.CSharp.Input |
…e segment is the same as a client
packages/http-client-csharp/emitter/src/lib/client-model-builder.ts
Outdated
Show resolved
Hide resolved
| badNamespaceSegments.add(lastSegment); | ||
|
|
||
| Logger.getInstance().warn( | ||
| `bad namespace ${client.clientNamespace} for client ${clientName}, please use @clientNamespace to specify a different namespace or @clientName to specify a different name for the client`, |
There was a problem hiding this comment.
I don't think we should promote @clientNamespace as this introduces multiple ways to rename things. @clientName can rename any object type.
See this issue for additional comments on this topic
There was a problem hiding this comment.
do you mean we should put @clientName first here in the message?
There was a problem hiding this comment.
I see - I removed the clientNamespace part.
|
need to add the extension namespace of the pipeline when invoking the extension method from the helpers. |
ArcturusZhang
force-pushed
the
implement-namespace
branch
from
f1709bc to
a544bef
Compare
| using Client.Naming.Models; | ||
| using NUnit.Framework; | ||
| using ClientModel = Client.Naming.Models.ClientModel; | ||
| // using System.Threading.Tasks; |
There was a problem hiding this comment.
these test cases are removed because of this issue: #5653
| @@ -50,6 +50,12 @@ const $lib = createTypeSpecLibrary({ | |||
| default: paramMessage`${"message"}`, | |||
| }, | |||
| }, | |||
| "bad-namespace": { | |||
There was a problem hiding this comment.
Maybe "client-namespace-conflict"?
Fixes #5442
Fixes #5471
This PR contains the following:
removes thenamespaceconfiguration from the emitter because we no longer need it.removes themodel-namespaceconfiguration from the emitter because we no longer need it.Because this change changes the namespace of literally everything, there are quite a few file changed. Majority of them are the generated files changed for the namespace.
For 2 and 3, since it impacts azure generator, I would like to do them in a standalone PR.