Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report nice error message when dotnet is not installed or not valid #5477

Merged
merged 34 commits into from
Jan 22, 2025
Merged

report nice error message when dotnet is not installed or not valid #5477

merged 34 commits into from
Jan 22, 2025

Conversation

chunyu3
Copy link
Contributor

@chunyu3 chunyu3 commented Jan 3, 2025 •
edited
Loading

Fix #5364

  • add invalid-dotnet-sdk-dependency diagnostic
  • When dotnet generation fail, check dotnet to filter out the failure because of runtime dependency is not valid
    • dotnet sdk is not installed
    • the installed dotnet sdk is not meet with the version requirement.

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Jan 3, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@typespec/http-client-csharp

@chunyu3 chunyu3 requested a review from ArcturusZhang January 3, 2025 06:50
JoshLove-msft
JoshLove-msft requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@JoshLove-msft JoshLove-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few questions

@chunyu3 chunyu3 changed the title report nice error message when dotnet is not installed report nice error message when dotnet is not installed or not valid Jan 13, 2025
@chunyu3 chunyu3 requested a review from JoshLove-msft January 14, 2025 01:55
JoshLove-msft
JoshLove-msft previously requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@JoshLove-msft JoshLove-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few additional comments, but overall looks like a nice improvement to the UX.

jsquire
jsquire requested changes Jan 15, 2025
View reviewed changes
packages/http-client-csharp/emitter/src/constants.ts Outdated Show resolved Hide resolved
packages/http-client-csharp/emitter/src/emitter.ts Outdated Show resolved Hide resolved
packages/http-client-csharp/emitter/src/emitter.ts Outdated Show resolved Hide resolved
packages/http-client-csharp/emitter/src/emitter.ts Outdated Show resolved Hide resolved
packages/http-client-csharp/emitter/src/emitter.ts Outdated Show resolved Hide resolved
packages/http-client-csharp/emitter/src/emitter.ts Outdated Show resolved Hide resolved
packages/http-client-csharp/emitter/src/lib/lib.ts Outdated Show resolved Hide resolved
packages/http-client-csharp/emitter/src/lib/lib.ts Outdated Show resolved Hide resolved
packages/http-client-csharp/emitter/src/lib/lib.ts Outdated Show resolved Hide resolved
packages/http-client-csharp/emitter/src/lib/lib.ts Outdated Show resolved Hide resolved
@chunyu3 chunyu3 requested a review from jsquire January 20, 2025 08:03
jsquire
jsquire reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll clear my request for changes and let @JoshLove-msft make the final decision on when to move forward.

@jsquire jsquire dismissed their stale review January 21, 2025 20:10

Updates resolved concerns.

@chunyu3 chunyu3 dismissed JoshLove-msft’s stale review January 22, 2025 00:39

the comments are all resolved.

@chunyu3 chunyu3 added this pull request to the merge queue Jan 22, 2025
Merged via the queue into microsoft:main with commit 06bc35c Jan 22, 2025
21 checks passed
@chunyu3 chunyu3 deleted the Fix5364 branch January 22, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsquire jsquire jsquire left review comments

@JoshLove-msft JoshLove-msft JoshLove-msft approved these changes

@archerzz archerzz archerzz approved these changes

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang

Assignees
No one assigned
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: C# emitter should explain simply that .NET needs to be installed
6 participants
@chunyu3 @azure-sdk @archerzz @jsquire @ArcturusZhang @JoshLove-msft