Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use EsBuild instead of rollup for vscode #6676

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Use EsBuild instead of rollup for vscode #6676

wants to merge 13 commits into from

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Mar 25, 2025 •
edited
Loading

fix #6370

Similar change done for prettier extension which is the only other thing still relying on rollup #6678

Still testing, but this simplify a lot and should get rid of all rollup deps having type issues and is much faster

Other change:

  • make sure test files are not included in bundle

@timotheeguerin timotheeguerin changed the title Seems to work Use EsBuild instead of rollup for vscode Mar 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/internal-build-utils
  • ✅ typespec-vscode
Show changes

typespec-vscode - internal ✏️

Change build system to use esbuild

@typespec/internal-build-utils - fix ✏️

Fix third party resolution getting duplicate entries

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 25, 2025 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@timotheeguerin timotheeguerin marked this pull request as ready for review March 25, 2025 22:58
RodgeFu
RodgeFu reviewed Mar 29, 2025
View reviewed changes
packages/typespec-vscode/src/extension-state-manager.ts
@@ -1,8 +1,8 @@
import { LogLevel } from "rollup";
Copy link
Contributor

@RodgeFu RodgeFu Mar 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an incorrect import by mistake, should import from ./log/logger.ts. so you dont need another LogLevel below

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RodgeFu RodgeFu RodgeFu left review comments

@lirenhe lirenhe Awaiting requested review from lirenhe lirenhe is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@chrisradek chrisradek Awaiting requested review from chrisradek chrisradek is a code owner

@AlitzelMendez AlitzelMendez Awaiting requested review from AlitzelMendez AlitzelMendez is a code owner

@witemple-msft witemple-msft Awaiting requested review from witemple-msft witemple-msft is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate if vscode extension can stop use esbuild or vite instead of rollup
3 participants
@timotheeguerin @azure-sdk @RodgeFu